Update ServiceResaleItem fields/record_refs for 2021.2 #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A couple were missing for my use case, so I updated them based on 2021.2 The following "fields" were removed as "fields" since they require specialized record classes that haven't been implemented yet: - cost_estimate_type - item_options_list - matrix_type - out_of_stock_behavior - overall_quantity_pricing_type - presentation_item_list - site_category_list - sitemap_priority - translations_list - vsoe_deferral - vsoe_permit_discount - vsoe_sop_group I arbitrarily went back 5 years (to version 2016.1) and these were all using specialized types back then, so this doesn't appear to have been a recent change on the NetSuite side of things that might affect users of this gem.
cgunther
force-pushed
the
service-resale-fields
branch
from
2b9d35f
to
ada4de2
Compare
iloveitaly
approved these changes
Dec 14, 2021
cgunther
added a commit
to cgunther/netsuite
that referenced
this pull request
Dec 16, 2021
I jumped the gun in NetSweet#500 and removed these fields assuming their custom types had to be implemented in the gem, but a few were just enums, such as `sitemap_priority`, which shouldn't need a custom type class as we get a string value back: ```xml <listAcct:sitemapPriority>_auto</listAcct:sitemapPriority> ``` https://system.netsuite.com/help/helpcenter/en_US/srbrowser/Browser2021_2/schema/enum/sitemappriority.html?mode=package Perhaps one day these enums should exist in the gem so you can refer to the values by something like a constant rather than a magic string (ie. `SitemapPriority::AUTO` vs "_auto"), but for now, the magic string is probably sufficient.
iloveitaly
pushed a commit
that referenced
this pull request
Dec 16, 2021
I jumped the gun in #500 and removed these fields assuming their custom types had to be implemented in the gem, but a few were just enums, such as `sitemap_priority`, which shouldn't need a custom type class as we get a string value back: ```xml <listAcct:sitemapPriority>_auto</listAcct:sitemapPriority> ``` https://system.netsuite.com/help/helpcenter/en_US/srbrowser/Browser2021_2/schema/enum/sitemappriority.html?mode=package Perhaps one day these enums should exist in the gem so you can refer to the values by something like a constant rather than a magic string (ie. `SitemapPriority::AUTO` vs "_auto"), but for now, the magic string is probably sufficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple were missing for my use case, so I updated them based on 2021.2
The following "fields" were removed as "fields" since they require
specialized record classes that haven't been implemented yet:
I arbitrarily went back 5 years (to version 2016.1) and these were all
using specialized types back then, so this doesn't appear to have been a
recent change on the NetSuite side of things that might affect users of
this gem.