Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SemVerLike compat to app cast maker #581

Merged
merged 20 commits into from
Jun 21, 2024

Conversation

Deadpikle
Copy link
Collaborator

@Deadpikle Deadpikle commented Jun 9, 2024

Tries to get SemVerLike compat into the app cast generator

  • Works for assembly versions
  • Works for manual --file-version
  • Fix comparisons so everything looks at SemVerLike objects
  • Add unit tests
  • Add unit tests that read off assembly version (how can we do this with unit tests when this requires a compiled binary...? probably need to do some Mock sort of something here.)
  • In the CanMakeAppCastWithAssemblyData unit test, read in the app cast from disk and make sure it reads things in properly.
  • Add parsing of file names off disk for SemVerLike so you can have MyApp 1.0-beta1.exe on disk and it parses correctly without breaking any of the old parsing methods (may require an additional flag if not backwards compat)
    • Right now 1.1.0-beta.1 parses to 1.1.0.1

Deadpikle added 2 commits June 9, 2024 22:13
Does not work for file name parsing at this time
@Deadpikle Deadpikle marked this pull request as ready for review June 21, 2024 07:38
@Deadpikle Deadpikle merged commit 9b5f25e into develop Jun 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants