Null checks for comma-separated lists

NetSparkleUpdater · Nov 22, 2023 · 608bf0b · 608bf0b
1 parent 04141da
commit 608bf0b
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/src/NetSparkle.Tools.AppCastGenerator/AppCastMaker.cs b/src/NetSparkle.Tools.AppCastGenerator/AppCastMaker.cs
@@ -296,7 +296,7 @@ public string GetPathToAppCastOutput(string desiredOutputDirectory, string sourc
         public (List<AppCastItem>, string) LoadAppCastItemsAndProductName(string sourceBinaryDirectory, bool useExistingAppCastItems, string outputAppCastFileName)
         {
             var items = new List<AppCastItem>();
-            var dirFileSearches = GetSearchExtensionsFromString(_opts.Extensions);
+            var dirFileSearches = GetSearchExtensionsFromString(_opts.Extensions ?? "");
             var binaries = FindBinaries(sourceBinaryDirectory, dirFileSearches, _opts.SearchBinarySubDirectories);
             if (!binaries.Any())
             {
@@ -382,14 +382,17 @@ public string GetPathToAppCastOutput(string desiredOutputDirectory, string sourc
                 items.Sort((a, b) => b.Version.CompareTo(a.Version));
 
                 // mark critical items as critical
-                var criticalVersions = _opts.CriticalVersions.Split(",").ToList()
+                var criticalVersions = _opts.CriticalVersions?.Split(",").ToList()
                     .Where(x => !string.IsNullOrWhiteSpace(x))
                     .Distinct();
-                foreach (var item in items)
+                if (criticalVersions != null)
                 {
-                    if (criticalVersions.Contains(item.Version))
+                    foreach (var item in items)
                     {
-                        item.IsCriticalUpdate = true;
+                        if (criticalVersions.Contains(item.Version))
+                        {
+                            item.IsCriticalUpdate = true;
+                        }
                     }
                 }