Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复 runtime 变量环境编译导致的bug #16201

Merged
merged 6 commits into from
Jul 29, 2024
Merged

fix: 修复 runtime 变量环境编译导致的bug #16201

merged 6 commits into from
Jul 29, 2024

Conversation

ZEJIA-LIU
Copy link
Contributor

This reverts commit 12c4264.

这个 PR 做了什么? (简要描述所做更改)
fix: 修复 runtime 变量环境编译导致的bug

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue: fix #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)
  • 鸿蒙(harmony)

@ZEJIA-LIU ZEJIA-LIU requested a review from liqinuo July 29, 2024 15:16
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.05%. Comparing base (c6a8514) to head (10914d9).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16201      +/-   ##
==========================================
- Coverage   61.06%   61.05%   -0.01%     
==========================================
  Files         445      445              
  Lines       22944    22941       -3     
  Branches     5021     4990      -31     
==========================================
- Hits        14010    14007       -3     
  Misses       7957     7957              
  Partials      977      977              
Flag Coverage Δ
taro-cli 73.67% <ø> (ø)
taro-runtime 59.83% <100.00%> (-0.10%) ⬇️
taro-web 52.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/taro-runtime/src/bom/URL.ts 45.98% <100.00%> (ø)
packages/taro-runtime/src/bom/URLSearchParams.ts 30.26% <100.00%> (ø)
packages/taro-runtime/src/bom/getComputedStyle.ts 66.66% <100.00%> (-8.34%) ⬇️
packages/taro-runtime/src/bom/history.ts 40.00% <100.00%> (ø)
packages/taro-runtime/src/bom/location.ts 16.56% <100.00%> (ø)
packages/taro-runtime/src/bom/navigator.ts 100.00% <100.00%> (ø)
packages/taro-runtime/src/bom/raf.ts 45.00% <100.00%> (-2.62%) ⬇️
packages/taro-runtime/src/bom/window.ts 63.79% <100.00%> (ø)
packages/taro-runtime/src/env.ts 100.00% <100.00%> (ø)

@liqinuo liqinuo merged commit 39fb4bf into main Jul 29, 2024
38 checks passed
@liqinuo liqinuo deleted the fix/runtine branch July 29, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants