Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 优化 chooseLocation 异常 #15214

Merged
merged 2 commits into from
Feb 18, 2024

Conversation

Hector-Chong
Copy link
Contributor

Description

LOCATION_APIKEY 未设置,将导致 JS 直接抛出 LOCATION_APIKEY is not defined 异常, 这里应该 Reject 以告知开发者此参数未配置。

image

  • 错误修复(Bugfix) issue: fix #

  • 新功能(Feature)

  • 代码重构(Refactor)

  • TypeScript 类型定义修改(Typings)

  • 文档修改(Docs)

  • 代码风格更新(Code style update)

  • 其他,请描述(Other, please describe):

  • 所有小程序

  • 微信小程序

  • 支付宝小程序

  • 百度小程序

  • 字节跳动小程序

  • QQ 轻应用

  • 京东小程序

  • 快应用平台(QuickApp)

  • Web 平台(H5)

  • 移动端(React-Native)

  • 鸿蒙(harmony)

Copy link

taro-bot2 bot commented Feb 6, 2024

欢迎提交 PR~ Taro 非常感谢您对开源事业做出的贡献!🌷🌷🌷

一般 PR 会在一到两周内进行 review,成功合入后会随下一个版本进行发布。

Review 需要耗费大量时间,所以请遵循以下规范,协助我们提高 review 效率🙏🙏🙏

  1. 详细介绍 PR 的背景(非常重要,例如解决了什么问题,该问题如何复现等)
  2. 确保 CI 顺利运行。
  3. 最好能提供对应的测试用例。

为了更好地进行沟通,请加入 Taro 开发者微信群:

Copy link
Contributor

@ZakaryCode ZakaryCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢贡献

Copy link

codecov bot commented Feb 18, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (d4d2985) 58.86% compared to head (780df5e) 58.86%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #15214   +/-   ##
=======================================
  Coverage   58.86%   58.86%           
=======================================
  Files         489      489           
  Lines       21728    21728           
  Branches     5576     5576           
=======================================
  Hits        12790    12790           
- Misses       7761     7780   +19     
+ Partials     1177     1158   -19     
Flag Coverage Δ
taro-cli 57.36% <ø> (-5.93%) ⬇️
taro-runner 46.21% <ø> (ø)
taro-runtime 65.51% <ø> (ø)
taro-web 40.94% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ackages/taro-h5/src/api/location/chooseLocation.ts 3.44% <0.00%> (ø)

... and 11 files with indirect coverage changes

@ZakaryCode ZakaryCode merged commit 2c6cf0d into NervJS:main Feb 18, 2024
20 of 21 checks passed
ZakaryCode added a commit that referenced this pull request Feb 19, 2024
Co-authored-by: Zakary <zakarycode@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants