fix(component): 解决 preventDefault 引起的页面无法滚动的问题 #14987
Conversation
| @@ -404,7 +404,6 @@ export class MovableView { | |||
| if (this.disabled || !this.element || this.scaling || !this.touching || touches.length > 1) { | |||
| return | |||
| } | |||
| e.preventDefault() | |||
There was a problem hiding this comment.
这应该就是 movable 组件的特性？小程序上体验会和这个有区别么？
There was a problem hiding this comment.
直接去掉应该会有些问题，在moveable设置为垂直或全向滑动的时候，与外部的垂直滚动也会有冲突；如果判断出仅在内外部进行同方向滚动时，再禁止事件冒泡是否可以
There was a problem hiding this comment.
这样是否可行
if (direction !== "horizontal") {
e.preventDefault()
}There was a problem hiding this comment.
没太看懂，是不是这个意思
if (("水平滑动开启" && "水平方向发生移动") || ("垂直滑动开启" && "垂直方向发生移动")) {
e.preventDefault()
}
There was a problem hiding this comment.
@baosiqing 不好意思，手误了，已更正。常规情况下垂直滑动存在冲突的情况，我只期望当 direction = horizontal 时，跳过 e.preventDefault() 允许冒泡
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14987 +/- ##
==========================================
- Coverage 58.67% 58.67% -0.01%
==========================================
Files 489 489
Lines 21829 21830 +1
Branches 5611 5612 +1
==========================================
Hits 12809 12809
+ Misses 7860 7841 -19
- Partials 1160 1180 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
|
这个 PR 做了什么? (简要描述所做更改)
解决 MovableView 组件事件中使用 preventDefault 引起的页面无法滚动的问题
这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台: