Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: h5模式下页面返回destroyed、onShow生命周期时序修复 #14303

Merged
merged 4 commits into from
Aug 11, 2023

Conversation

voidman2017
Copy link
Contributor

这个 PR 做了什么? (简要描述所做更改)
修复web平台下,页面返回(PageB 返回 PageA)时,生命周期 destroyed 和 onShow 时序与小程序不一致问题
现状:小程序下 PageB.destroyed -> PageA.onShow; h5端 PageA.onShow -> PageB.destroyed
修复之后两端一致

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue: fix #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • [] 移动端(React-Native)
  • 鸿蒙(harmony)

@taro-bot2
Copy link

taro-bot2 bot commented Aug 4, 2023

欢迎提交 PR~ Taro 非常感谢您对开源事业做出的贡献!🌷🌷🌷

一般 PR 会在一到两周内进行 review,成功合入后会随下一个版本进行发布。

Review 需要耗费大量时间,所以请遵循以下规范,协助我们提高 review 效率🙏🙏🙏

  1. 详细介绍 PR 的背景(非常重要,例如解决了什么问题,该问题如何复现等)
  2. 确保 CI 顺利运行。
  3. 最好能提供对应的测试用例。

为了更好地进行沟通,请加入 Taro 开发者微信群:

packages/taro-router/src/router/spa.ts Outdated Show resolved Hide resolved
packages/taro-router/src/router/page.ts Outdated Show resolved Hide resolved
packages/taro-router/src/router/page.ts Outdated Show resolved Hide resolved
packages/taro-router/src/router/page.ts Outdated Show resolved Hide resolved
@ZakaryCode ZakaryCode added A-router Area - H5 路由相关 T-h5 Target - 编译到 H5 labels Aug 7, 2023
@Chen-jj Chen-jj added this to the 3.6.12 milestone Aug 11, 2023
@ZakaryCode
Copy link
Contributor

感谢贡献

@ZakaryCode ZakaryCode merged commit 2988a9e into NervJS:next Aug 11, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-router Area - H5 路由相关 T-h5 Target - 编译到 H5
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants