Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alipay): add my.alert success callback compatibility #14267

Merged
merged 4 commits into from
Aug 2, 2023

Conversation

TheKonka
Copy link
Member

这个 PR 做了什么? (简要描述所做更改)
Taro.showModal 方法 showCancel==false 时实际调用的是my.alert方法,此时,回调只返回了 {success:true},此处作统一兼容,同时返回 confirm属性

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue: fix #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)
  • 鸿蒙(harmony)

@ZakaryCode ZakaryCode merged commit cd62c0d into NervJS:next Aug 2, 2023
4 checks passed
@TheKonka TheKonka deleted the fix-alipay-alert branch August 2, 2023 03:06
yechunxi pushed a commit to yechunxi/taro that referenced this pull request Aug 4, 2023
* fix(alipay): add my.alert success callback compatibility

* test: update snapshots

---------

Co-authored-by: chenjiajian <798095202@qq.com>
Co-authored-by: Zakary <zakarycode@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants