refactor(taroize) 删除无用文件，重构部分函数 (#4333)

* taroize#reconstruction Taroize微重构 * taroize#reconstruction Taroize微重构，增加参数类型
NervJS · Aug 29, 2019 · d7945c2 · d7945c2
1 parent 51a2415
commit d7945c2
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 57 deletions.
diff --git a/packages/taroize/src/lifecycle.ts b/packages/taroize/src/lifecycle.ts
diff --git a/packages/taroize/src/script.ts b/packages/taroize/src/script.ts
@@ -10,6 +10,26 @@ const buildDecorator = (id: t.Identifier | t.ObjectExpression) => t.decorator(
   t.callExpression(t.identifier('withWeapp'), [id])
 )
 
+function replaceIdentifier (callee: NodePath<t.Node>) {
+  if (callee.isIdentifier()) {
+    const name = callee.node.name
+    if (name === 'getApp' || name === 'getCurrentPages') {
+      callee.replaceWith(
+        t.memberExpression(t.identifier('Taro'), callee.node)
+      )
+    }
+  }
+}
+
+function replaceMemberExpression (callee: NodePath<t.Node>) {
+  if (callee.isMemberExpression()) {
+    const object = callee.get('object')
+    if (object.isIdentifier({ name: 'wx' })) {
+      object.replaceWith(t.identifier('Taro'))
+    }
+  }
+}
+
 export function parseScript (
   script?: string,
   returned?: t.Expression,
@@ -37,20 +57,8 @@ export function parseScript (
     },
     CallExpression (path) {
       const callee = path.get('callee')
-      if (callee.isIdentifier()) {
-        const name = callee.node.name
-        if (name === 'getApp' || name === 'getCurrentPages') {
-          callee.replaceWith(
-            t.memberExpression(t.identifier('Taro'), callee.node)
-          )
-        }
-      }
-      if (callee.isMemberExpression()) {
-        const object = callee.get('object')
-        if (object.isIdentifier({ name: 'wx' })) {
-          object.replaceWith(t.identifier('Taro'))
-        }
-      }
+      replaceIdentifier(callee)
+      replaceMemberExpression(callee)
       if (
         callee.isIdentifier({ name: 'Page' }) ||
         callee.isIdentifier({ name: 'Component' }) ||
@@ -114,23 +122,8 @@ function parsePage (
   pagePath.traverse({
     CallExpression (path) {
       const callee = path.get('callee')
-      if (callee.isIdentifier()) {
-        const name = callee.node.name
-        if (name === 'getApp' || name === 'getCurrentPages') {
-          callee.replaceWith(
-            t.memberExpression(t.identifier('Taro'), callee.node)
-          )
-        }
-      }
-      if (callee.isMemberExpression()) {
-        const object = callee.get('object')
-        if (object.isIdentifier()) {
-          const objectName = object.node.name
-          if (objectName === 'wx') {
-            object.replaceWith(t.identifier('Taro'))
-          }
-        }
-      }
+      replaceIdentifier(callee)
+      replaceMemberExpression(callee)
     }
   })
   if (refId) {