Added configs for Neon VLLM service #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeonDaniel
reviewed
Nov 1, 2024
There was a problem hiding this comment.
Left a couple comments based on reading through changes.
- I will address the chart version note and update Helm charts
- After updating the chart version, I will test this by generating new charts and deploying to the
alphanamespace and leave another review here
NeonDaniel
force-pushed
the
support_for_vllm
branch
from
98d3352 to
2d6f08b
Compare
NeonDaniel
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added configuration to deploy Neon VLLM service via Diana Helm