Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace rest-client with smth #21

Open
Neodelf opened this issue Apr 9, 2020 · 3 comments · Fixed by #68
Open

Replace rest-client with smth #21

Neodelf opened this issue Apr 9, 2020 · 3 comments · Fixed by #68
Labels
dependencies Pull requests that update a dependency file good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Neodelf
Copy link
Owner

Neodelf commented Apr 9, 2020

They're using rest-client gem.
This is a very heavy-weight library. So I want to replace it with the native ruby library or better http gem.
@pineapplethief
Copy link
Contributor

+1 for http.rb gem

@Neodelf Neodelf added dependencies Pull requests that update a dependency file help wanted Extra attention is needed good first issue Good for newcomers labels Apr 21, 2020
@Neodelf
Copy link
Owner Author

Neodelf commented Apr 21, 2020 •
edited
Loading

@pineapplethief yep, I hope their measuring is correct))

oskaror added a commit to oskaror/lecter that referenced this issue Feb 2, 2022
@oskaror
[Fix Neodelf#21] Replace rest-client with http.rb
c15ea70
@oskaror oskaror mentioned this issue Feb 2, 2022
Merged
7 tasks
oskaror added a commit to oskaror/lecter that referenced this issue Feb 2, 2022
@oskaror
[Fix Neodelf#21] Replace rest-client with http.rb
9831316
@Neodelf Neodelf reopened this Feb 15, 2022
@Neodelf
Copy link
Owner Author

Neodelf commented Feb 15, 2022

I reverted the PR #68 cause there was a problem. Cause HTTP.rb gem has a different interface to add params to the GET request. So a lecter_enabled parameter was not added correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace rest-client with http.rb oskaror/lecter
2 participants
@Neodelf @pineapplethief