Crashing when clicked on Customize Icons

[Surendrajat]

Description

Just crash...

Expected Behavior

Should open icon customization view.

Actual Behavior

App crashes.

Steps to Reproduce

1. Long press on Home Screen.
2. Click on Home Settings.
3. Click on Theme Settings.
4. Click on Customize Icons.

Device and OS

• Device: Oppo K3
• Android version: 10
• Launcher version: latest build from CI
• Rom: ColorOS v7.1

Logcat

Build version: 0.6.3 
Build date: 1981-01-01 01:01:02 
Current date: 2021-01-09 19:14:29 
Device: OPPO CPH1955 
 
Stack trace:  
android.view.InflateException: Binary XML file line #22 in com.saggitt.omega:layout/fragment_icon_customization: Parameter specified as non-null is null: method kotlin.jvm.internal.Intrinsics.checkNotNullParameter, parameter iconShape
Caused by: java.lang.NullPointerException: Parameter specified as non-null is null: method kotlin.jvm.internal.Intrinsics.checkNotNullParameter, parameter iconShape
	at com.saggitt.omega.adaptive.IconShapeDrawable.<init>(Unknown Source:2)
	at com.saggitt.omega.icons.PreviewFrameView.loadBackground(PreviewFrameView.java:92)
	at com.saggitt.omega.icons.PreviewFrameView.onFinishInflate(PreviewFrameView.java:75)
	at android.view.LayoutInflater.rInflate(LayoutInflater.java:1138)
	at android.view.LayoutInflater.rInflateChildren(LayoutInflater.java:1086)
	at android.view.LayoutInflater.parseInclude(LayoutInflater.java:1265)
	at android.view.LayoutInflater.rInflate(LayoutInflater.java:1121)
	at android.view.LayoutInflater.rInflateChildren(LayoutInflater.java:1086)
	at android.view.LayoutInflater.inflate(LayoutInflater.java:682)
	at com.saggitt.omega.OmegaLayoutInflater.inflate(OmegaLayoutInflater.kt:94)
	at android.view.LayoutInflater.inflate(LayoutInflater.java:534)
	at com.saggitt.omega.icons.IconCustomizeFragment.onCreateView(IconCustomizeFragment.java:102)
	at androidx.fragment.app.Fragment.performCreateView(Fragment.java:2698)
	at androidx.fragment.app.FragmentStateManager.createView(FragmentStateManager.java:320)
	at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1187)
	at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1356)
	at androidx.fragment.app.FragmentManager.moveFragmentToExpectedState(FragmentManager.java:1434)
	at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1497)
	at androidx.fragment.app.BackStackRecord.executeOps(BackStackRecord.java:447)
	at androidx.fragment.app.FragmentManager.executeOps(FragmentManager.java:2169)
	at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:1992)
	at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:1947)
	at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:1849)
	at androidx.fragment.app.FragmentManager.dispatchStateChange(FragmentManager.java:2629)
	at androidx.fragment.app.FragmentManager.dispatchActivityCreated(FragmentManager.java:2577)
	at androidx.fragment.app.FragmentController.dispatchActivityCreated(FragmentController.java:247)
	at androidx.fragment.app.FragmentActivity.onStart(FragmentActivity.java:541)
	at androidx.appcompat.app.AppCompatActivity.onStart(AppCompatActivity.java:210)
	at android.app.Instrumentation.callActivityOnStart(Instrumentation.java:1433)
	at android.app.Activity.performStart(Activity.java:7986)
	at android.app.ActivityThread.handleStartActivity(ActivityThread.java:3528)
	at android.app.servertransaction.TransactionExecutor.performLifecycleSequence(TransactionExecutor.java:226)
	at android.app.servertransaction.TransactionExecutor.cycleToPath(TransactionExecutor.java:206)
	at android.app.servertransaction.TransactionExecutor.executeLifecycleState(TransactionExecutor.java:178)
	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:102)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2229)
	at android.os.Handler.dispatchMessage(Handler.java:107)
	at android.os.Looper.loop(Looper.java:238)
	at android.app.ActivityThread.main(ActivityThread.java:7798)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:492)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:995)

[2br-2b]

I am still having this problem on the most recent release. Is there any chance of a new release coming out soon which will include the fix?

Thank you so much for your work! I love all the work you're putting into this and all of the customization options possible!

[2br-2b]

Device: Pixel 4XL
Android version: 11
Launcher version: latest version from Fdroid (0.7.1)
Rom: GrapheneOS

[saulhdev]

fixed in commit 81c8f52