Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and unify one!, zero!, neg! methods for arb types #1900

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

fingolfin
Copy link
Member

No description provided.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 68.49315% with 46 lines in your changes missing coverage. Please review.

Project coverage is 87.25%. Comparing base (677fbcf) to head (e9ec375).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/arb/Complex.jl 77.27% 5 Missing ⚠️
src/arb/ComplexPoly.jl 54.54% 5 Missing ⚠️
src/arb/RealPoly.jl 37.50% 5 Missing ⚠️
src/arb/acb.jl 76.19% 5 Missing ⚠️
src/arb/acb_poly.jl 54.54% 5 Missing ⚠️
src/arb/arb_poly.jl 37.50% 5 Missing ⚠️
src/arb/ComplexMat.jl 75.00% 3 Missing ⚠️
src/arb/RealMat.jl 75.00% 3 Missing ⚠️
src/arb/acb_mat.jl 75.00% 3 Missing ⚠️
src/arb/arb_mat.jl 75.00% 3 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1900      +/-   ##
==========================================
+ Coverage   87.22%   87.25%   +0.02%     
==========================================
  Files          97       97              
  Lines       35652    35655       +3     
==========================================
+ Hits        31098    31109      +11     
+ Misses       4554     4546       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@lgoettgens lgoettgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good, thanks!

@fingolfin fingolfin enabled auto-merge (squash) October 15, 2024 10:31
@fingolfin fingolfin merged commit 1e48bb0 into master Oct 15, 2024
24 of 25 checks passed
@fingolfin fingolfin deleted the mh/zero-one-neg-more branch October 15, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants