feat: inplace scalar multiplication for FqMatrix #1797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1797 +/- ##
==========================================
- Coverage 85.92% 85.90% -0.02%
==========================================
Files 95 95
Lines 36374 36389 +15
==========================================
+ Hits 31253 31261 +8
- Misses 5121 5128 +7 ☔ View full report in Codecov by Sentry. |
lgoettgens
reviewed
Jun 21, 2024
Comment on lines
+352
to
+349
| a = F17[1 2 3 1; 3 2 1 2; 1 3 2 0] | ||
| z = F17(2) | ||
| b = similar(a) | ||
| @test mul!(b, a, z) == a * z | ||
| b = similar(a) | ||
| @test mul!(b, z, a) == a * z |
There was a problem hiding this comment.
What is the difference between this block and the one prior? I cannot see any changes
There was a problem hiding this comment.
Yeah, that's L355 vs L357. I was asking about L345-350 vs L352-357
(There exists no corresponding function in flint)
lgoettgens
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(There exists no corresponding function in flint)