add coeff methods for fpFieldElem and FpFieldElem
#1796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1796 +/- ##
==========================================
- Coverage 85.92% 85.89% -0.03%
==========================================
Files 95 95
Lines 36374 36382 +8
==========================================
- Hits 31253 31252 -1
- Misses 5121 5130 +9 ☔ View full report in Codecov by Sentry. |
|
I will have a look later today |
thofma
reviewed
Jun 19, 2024
Co-authored-by: Tommy Hofmann <thofma@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
coeffmethods for these finite field types to be consistent with the other finite field types.Fixes thofma/Hecke.jl#1546