Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop redundant check_parent methods #1784

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

fingolfin
Copy link
Member

... in favor of generic one from AA 0.41.9

Some removed methods are for matrices, and didn't check the parent, but instead the base ring, ncols, nrows -- but they should be fine performance-wise because the check_parent(a::MatrixElem, b::MatrixElem, throw::Bool = true) method from AA should kick in which does just that.

Alas in practice it seems something is still broken, tests fail, so I assume I screwed something up. But I am posting this as a draft here now so I won't forget about it.

... in favor of generic one from AA 0.41.9
@thofma
Copy link
Member

thofma commented Jun 7, 2024

@joschmitt can you have a look? it is failing in the solving

@joschmitt
Copy link
Collaborator

joschmitt commented Jun 7, 2024

@joschmitt can you have a look? it is failing in the solving

Apparently, I assumed that check_parent for matrices only checks whether the base rings coincide. This didn't hurt so far because the check_parent methods for finite fields only complain if the number of rows AND columns differ but not if only one of them differs. I assume that this is a mistake.

I will open a pull request (#1785) that makes the correct checks in the linear solving methods and then you can rebase this or cherry-pick.

src/arb/Complex.jl Show resolved Hide resolved
src/arb/Real.jl Show resolved Hide resolved
src/calcium/qqbar.jl Show resolved Hide resolved
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.72%. Comparing base (8aedf5e) to head (8201899).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1784      +/-   ##
==========================================
- Coverage   85.90%   85.72%   -0.19%     
==========================================
  Files          95       95              
  Lines       36491    36355     -136     
==========================================
- Hits        31349    31164     -185     
- Misses       5142     5191      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fingolfin fingolfin marked this pull request as ready for review June 10, 2024 10:06
@lgoettgens
Copy link
Collaborator

This is ready to go from my POV, but I cannot merge it due to required CI jobs not running. @fingolfin maybe you just do it yourself then?

@fingolfin fingolfin merged commit fff6c38 into Nemocas:master Jun 12, 2024
35 of 50 checks passed
@fingolfin fingolfin deleted the mh/check_parent branch June 12, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants