-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop redundant check_parent methods #1784
Conversation
... in favor of generic one from AA 0.41.9
@joschmitt can you have a look? it is failing in the solving |
Apparently, I assumed that I will open a pull request (#1785) that makes the correct checks in the linear solving methods and then you can rebase this or cherry-pick. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1784 +/- ##
==========================================
- Coverage 85.90% 85.72% -0.19%
==========================================
Files 95 95
Lines 36491 36355 -136
==========================================
- Hits 31349 31164 -185
- Misses 5142 5191 +49 ☔ View full report in Codecov by Sentry. |
This is ready to go from my POV, but I cannot merge it due to required CI jobs not running. @fingolfin maybe you just do it yourself then? |
... in favor of generic one from AA 0.41.9
Some removed methods are for matrices, and didn't check the parent, but instead the base ring, ncols, nrows -- but they should be fine performance-wise because the
check_parent(a::MatrixElem, b::MatrixElem, throw::Bool = true)
method from AA should kick in which does just that.Alas in practice it seems something is still broken, tests fail, so I assume I screwed something up. But I am posting this as a draft here now so I won't forget about it.