Restrict round signature to avoid ambiguities, and add adhoc comparision for ZZRingElem and Rational{T} #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1558 +/- ##
==========================================
- Coverage 84.19% 84.19% -0.01%
==========================================
Files 94 94
Lines 36602 36610 +8
==========================================
+ Hits 30818 30824 +6
- Misses 5784 5786 +2
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fingolfin
force-pushed
the
mh/round-ambiguity
branch
from
83fd4d0
to
c27c988
Compare
fingolfin
force-pushed
the
mh/round-ambiguity
branch
from
c27c988
to
36d0299
Compare
fingolfin
changed the title
fingolfin
force-pushed
the
mh/round-ambiguity
branch
from
36d0299
to
ce08fca
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.