Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pirated stuff to AbstractAlgebra #1531

Merged
merged 6 commits into from
Sep 13, 2023
Merged

Conversation

lgoettgens
Copy link
Collaborator

@lgoettgens lgoettgens commented Sep 4, 2023

A big step towards #1495. The counterpart is Nemocas/AbstractAlgebra.jl#1412.

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #1531 (ab2ed13) into master (ab2dfc1) will increase coverage by 1.08%.
Report is 5 commits behind head on master.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1531      +/-   ##
==========================================
+ Coverage   82.90%   83.98%   +1.08%     
==========================================
  Files          94       94              
  Lines       37141    36613     -528     
==========================================
- Hits        30790    30751      -39     
+ Misses       6351     5862     -489     
Files Changed Coverage Δ
src/HeckeMiscFiniteField.jl 38.82% <ø> (+0.22%) ⬆️
src/HeckeMiscInteger.jl 14.60% <ø> (-1.51%) ⬇️
src/HeckeMiscMatrix.jl 19.70% <0.00%> (+6.10%) ⬆️
src/HeckeMiscPoly.jl 7.79% <ø> (-0.41%) ⬇️
src/HeckeMoreStuff.jl 2.51% <ø> (-0.70%) ⬇️
src/flint/fq.jl 93.80% <ø> (-0.30%) ⬇️

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lgoettgens
Copy link
Collaborator Author

Failures here are to be expected, the OscarCI-matching CI in Nemocas/AbstractAlgebra.jl#1412 shows if everything is fine.

@lgoettgens lgoettgens marked this pull request as ready for review September 12, 2023 09:40
@thofma thofma merged commit 1da1aea into Nemocas:master Sep 13, 2023
13 of 15 checks passed
@lgoettgens lgoettgens deleted the lg/nemo-piracy branch September 13, 2023 14:30
@fingolfin fingolfin mentioned this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants