Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of AbstractAlgebra.error_dim_negative #1529

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

fingolfin
Copy link
Member

Note that src/error.jl was not even being included.

Note that src/error.jl was not even being included.
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #1529 (748916b) into master (fd27c97) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1529   +/-   ##
=======================================
  Coverage   82.87%   82.88%           
=======================================
  Files          94       94           
  Lines       37141    37141           
=======================================
+ Hits        30782    30783    +1     
+ Misses       6359     6358    -1     
Files Changed Coverage Δ
src/flint/FlintTypes.jl 94.40% <100.00%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fingolfin
Copy link
Member Author

@thofma @fieker OK to merge?

@thofma thofma merged commit a5e49fc into Nemocas:master Sep 1, 2023
15 checks passed
@fingolfin fingolfin deleted the mh/error branch September 1, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants