Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make divexact(::fmpq_poly, ::fmpq_poly) honour the check keyword #1523

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

joschmitt
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #1523 (9f67d86) into master (38fd074) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1523      +/-   ##
==========================================
+ Coverage   82.75%   82.76%   +0.01%     
==========================================
  Files          95       95              
  Lines       37186    37191       +5     
==========================================
+ Hits        30773    30782       +9     
+ Misses       6413     6409       -4     
Files Changed Coverage Δ
src/flint/fmpq_poly.jl 94.68% <100.00%> (+0.06%) ⬆️

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fingolfin
Copy link
Member

Maybe you could do a quick grep to see if there are other similarly flawed divexact methods hiding there? But consider this purely optional, if you have better things to do...

@joschmitt
Copy link
Collaborator Author

Maybe you could do a quick grep to see if there are other similarly flawed divexact methods hiding there? But consider this purely optional, if you have better things to do...

I can't find any other instance of this. But grepping for divexact gives around 1000 matches, so no guarantee...

@thofma thofma merged commit ae8f01c into Nemocas:master Aug 15, 2023
15 checks passed
@fingolfin
Copy link
Member

@joschmitt of course. Thank you!

@joschmitt joschmitt deleted the fix_divexact branch August 16, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants