Avoid use of deprecated aliases (#1556)

src/HeckeMiscPoly.jl

@@ -34,7 +34,7 @@ function (::ZZRing)(a::ZZModRingElem)
     return a.data
 end
 
-function rem!(z::T, f::T, g::T) where {T<:PolyElem}
+function rem!(z::T, f::T, g::T) where {T<:PolyRingElem}
     z = rem(f, g)
     return z
 end
@@ -311,7 +311,7 @@ end
 # This should avoid the full factorization for function fields
 # (and/or finitely generated fields in general?!)
 
-function factor_squarefree(f::PolyElem{<:FieldElement})
+function factor_squarefree(f::PolyRingElem{<:FieldElement})
     R = coefficient_ring(f)
     if iszero(characteristic(R))
         return _factor_squarefree_char_0(f)
@@ -333,7 +333,7 @@ end
 
 
 # This is Musser's algorithm
-function _factor_squarefree_char_0(f::PolyElem)
+function _factor_squarefree_char_0(f::PolyRingElem)
     @assert iszero(characteristic(base_ring(f)))
     res = Dict{typeof(f),Int}()
     if is_constant(f)
@@ -407,15 +407,15 @@ function mulhigh_n(a::ZZPolyRingElem, b::ZZPolyRingElem, n::Int)
     ccall((:fmpz_poly_mulhigh_n, libflint), Nothing, (Ref{ZZPolyRingElem}, Ref{ZZPolyRingElem}, Ref{ZZPolyRingElem}, Cint), c, a, b, n)
     return c
 end
-function mulhigh(a::PolyElem{T}, b::PolyElem{T}, n::Int) where {T}
+function mulhigh(a::PolyRingElem{T}, b::PolyRingElem{T}, n::Int) where {T}
     return mulhigh_n(a, b, degree(a) + degree(b) - n)
 end
 
 function (f::acb_poly)(x::acb)
     return evaluate(f, x)
 end
 
-function mod(f::AbstractAlgebra.PolyElem{T}, g::AbstractAlgebra.PolyElem{T}) where {T<:RingElem}
+function mod(f::AbstractAlgebra.PolyRingElem{T}, g::AbstractAlgebra.PolyRingElem{T}) where {T<:RingElem}
     check_parent(f, g)
     if length(g) == 0
         throw(DivideError())
@@ -442,7 +442,7 @@ end
 normalise(f::ZZPolyRingElem, ::Int) = degree(f) + 1
 set_length!(f::ZZPolyRingElem, ::Int) = nothing
 
-function Base.divrem(f::AbstractAlgebra.PolyElem{T}, g::AbstractAlgebra.PolyElem{T}) where {T<:RingElem}
+function Base.divrem(f::AbstractAlgebra.PolyRingElem{T}, g::AbstractAlgebra.PolyRingElem{T}) where {T<:RingElem}
     check_parent(f, g)
     if length(g) == 0
         throw(DivideError())
@@ -479,7 +479,7 @@ end
 ################################################################################
 
 @doc raw"""
-    Base.rand(Rt::PolyRing{T}, n::Int) where T <: ResElem{ZZRingElem} -> PolyElem{T}
+    Base.rand(Rt::PolyRing{T}, n::Int) where T <: ResElem{ZZRingElem} -> PolyRingElem{T}
 
 Find a random polynomial of degree=$n$.
 """
@@ -498,7 +498,7 @@ end
 #
 ################################################################################
 
-function is_squarefree(f::PolyElem{<:FieldElement})
+function is_squarefree(f::PolyRingElem{<:FieldElement})
   R = coefficient_ring(f)
 
   if iszero(f) || degree(f) == 0
@@ -519,7 +519,7 @@ function is_squarefree(f::PolyElem{<:FieldElement})
   end
 end
 
-function is_squarefree(f::PolyElem{<:RingElement})
+function is_squarefree(f::PolyRingElem{<:RingElement})
   if iszero(f)
     return true
   end

src/HeckeMoreStuff.jl

@@ -870,7 +870,7 @@ end
 # in triplicate.... and probably cases missing...
 export elem_to_mat_row!
 
-function elem_to_mat_row!(M::MatElem, i::Int, a::ResElem{T}) where {T<:PolyElem}
+function elem_to_mat_row!(M::MatElem, i::Int, a::ResElem{T}) where {T<:PolyRingElem}
     z = zero(parent(M[1, 1]))
     for j = 0:degree(a.data)
         M[i, j+1] = coeff(a.data, j)
@@ -1037,7 +1037,7 @@ function mul!(res::QQMPolyRingElem, a::QQMPolyRingElem, c::ZZRingElem)
 end
 
 #@doc raw"""
-#    is_univariate(f::Generic.MPoly{T}) where T <: NumFieldElem -> Bool, PolyElem{T}
+#    is_univariate(f::Generic.MPoly{T}) where T <: NumFieldElem -> Bool, PolyRingElem{T}
 #
 #Tests if $f$ involves only one variable. If so, return a corresponding univariate polynomial.
 #"""
@@ -1387,7 +1387,7 @@ function defining_polynomial(k::fpField)
     return x - k(1)
 end
 
-function norm(f::PolyElem{padic})
+function norm(f::PolyRingElem{padic})
     return f
 end
 

src/flint/fmpz.jl

@@ -3005,7 +3005,7 @@ is_prime_power(::IntegerUnion)
 function is_prime_power(q::ZZRingElem)
   iszero(q) && return false
   e, a = _maximal_integer_root(q)
-  return isprime(a)
+  return is_prime(a)
 end
 
 is_prime_power(q::Integer) = is_prime_power(ZZRingElem(q))
@@ -3021,12 +3021,12 @@ is_prime_power_with_data(::IntegerUnion)
 function is_prime_power_with_data(q::ZZRingElem)
   iszero(q) && return false, 1, q
   e, a = _maximal_integer_root(q)
-  return isprime(a), e, a
+  return is_prime(a), e, a
 end
 
 function is_prime_power_with_data(q::Integer)
   e, a = _maximal_integer_root(ZZRingElem(q))
-  return isprime(a), e, typeof(q)(a)
+  return is_prime(a), e, typeof(q)(a)
 end
 
 ###############################################################################

src/flint/fmpz_mod_abs_series.jl

@@ -775,7 +775,7 @@ function sqrt_classical(a::FpAbsPowerSeriesRingElem; check::Bool=true)
    a = shift_right(a, v)
    c = coeff(a, 0)
    if check
-      flag, s = issquare_with_sqrt(c)
+      flag, s = is_square_with_sqrt(c)
       if !flag
          return false, S()
       end
@@ -808,12 +808,12 @@ function Base.sqrt(a::FpAbsPowerSeriesRingElem; check::Bool=true)
    return s
 end
 
-function issquare(a::FpAbsPowerSeriesRingElem)
+function is_square(a::FpAbsPowerSeriesRingElem)
    flag, s = sqrt_classical(a; check=true)
    return flag
 end
 
-function issquare_with_sqrt(a::FpAbsPowerSeriesRingElem)
+function is_square_with_sqrt(a::FpAbsPowerSeriesRingElem)
    return sqrt_classical(a; check=true)
 end
 

src/flint/fmpz_mod_rel_series.jl

@@ -994,7 +994,7 @@ function sqrt_classical(a::FpRelPowerSeriesRingElem; check::Bool=true)
    z.val = v2
    c = coeff(a, v)
    if check
-      flag, s = issquare_with_sqrt(c)
+      flag, s = is_square_with_sqrt(c)
       if !flag
          return false, S()
       end
@@ -1027,11 +1027,11 @@ function Base.sqrt(a::FpRelPowerSeriesRingElem; check::Bool=true)
    return q
 end
 
-function issquare(a::FpRelPowerSeriesRingElem)
+function is_square(a::FpRelPowerSeriesRingElem)
    flag, q = sqrt_classical(a; check=true)
    return flag
 end
 
-function issquare_with_sqrt(a::FpRelPowerSeriesRingElem)
+function is_square_with_sqrt(a::FpRelPowerSeriesRingElem)
    return sqrt_classical(a; check=true)
 end

src/flint/fq_abs_series.jl

@@ -506,7 +506,7 @@ function sqrt_classical_char2(a::($etype); check::Bool=true)
    end
    for i = 0:prec - 1
       if check
-         flag, c = issquare_with_sqrt(coeff(a, 2*i))
+         flag, c = is_square_with_sqrt(coeff(a, 2*i))
          !flag && error("Not a square")
       else
          # degree of finite field could be > 1 so sqrt necessary here
@@ -535,7 +535,7 @@ function sqrt_classical(a::($etype); check::Bool=true)
    a = shift_right(a, v)
    c = coeff(a, 0)
    if check
-      flag, s = issquare_with_sqrt(c)
+      flag, s = is_square_with_sqrt(c)
       if !flag
          return false, S()
       end
@@ -562,12 +562,12 @@ function Base.sqrt(a::($etype); check::Bool=true)
    return s
 end
 
-function issquare(a::($etype))
+function is_square(a::($etype))
    flag, s = sqrt_classical(a; check=true)
    return flag
 end
 
-function issquare_with_sqrt(a::($etype))
+function is_square_with_sqrt(a::($etype))
    return sqrt_classical(a; check=true)
 end
 

src/flint/fq_default_abs_series.jl

@@ -490,7 +490,7 @@ function sqrt_classical_char2(a::FqAbsPowerSeriesRingElem; check::Bool=true)
    end
    for i = 0:prec - 1
       if check
-         flag, c = issquare_with_sqrt(coeff(a, 2*i))
+         flag, c = is_square_with_sqrt(coeff(a, 2*i))
          !flag && error("Not a square")
       else
          # degree of finite field could be > 1 so sqrt necessary here
@@ -519,7 +519,7 @@ function sqrt_classical(a::FqAbsPowerSeriesRingElem; check::Bool=true)
    a = shift_right(a, v)
    c = coeff(a, 0)
    if check
-      flag, s = issquare_with_sqrt(c)
+      flag, s = is_square_with_sqrt(c)
       if !flag
          return false, S()
       end
@@ -547,12 +547,12 @@ function Base.sqrt(a::FqAbsPowerSeriesRingElem; check::Bool=true)
    return s
 end
 
-function issquare(a::FqAbsPowerSeriesRingElem)
+function is_square(a::FqAbsPowerSeriesRingElem)
    flag, s = sqrt_classical(a; check=true)
    return flag
 end
 
-function issquare_with_sqrt(a::FqAbsPowerSeriesRingElem)
+function is_square_with_sqrt(a::FqAbsPowerSeriesRingElem)
    return sqrt_classical(a; check=true)
 end
 

src/flint/fq_default_extended.jl

@@ -644,7 +644,7 @@ function NGFiniteField(a::IntegerUnion, s::VarName = :o; cached::Bool = true, ch
 end
 
 function NGFiniteField(f::FqPolyRingElem, s::VarName = :o; cached::Bool = true, check::Bool = true, absolute::Bool = false)
-  (check && !isirreducible(f)) && error("Defining polynomial must be irreducible")
+  (check && !is_irreducible(f)) && error("Defining polynomial must be irreducible")
   # Should probably have its own cache
   F = FqField(f, Symbol(s), cached, absolute)
   return F, gen(F)

src/flint/fq_default_poly.jl

@@ -394,7 +394,7 @@ function sqrt(x::FqPolyRingElem; check::Bool=true)
    return s
 end
 
-function issquare(x::FqPolyRingElem)
+function is_square(x::FqPolyRingElem)
    if iszero(x)
       return true
    end
@@ -409,7 +409,7 @@ function issquare(x::FqPolyRingElem)
    return flag
 end
 
-function issquare_with_sqrt(x::FqPolyRingElem)
+function is_square_with_sqrt(x::FqPolyRingElem)
    R = parent(x)
    if iszero(x)
       return true, zero(R)

src/flint/fq_default_rel_series.jl

@@ -556,7 +556,7 @@ function sqrt_classical_char2(a::FqRelPowerSeriesRingElem; check::Bool=true)
    end
    for i = 0:prec - aval2 - 1
       c = polcoeff(a, 2*i)
-      if check && !issquare(c)
+      if check && !is_square(c)
          return false, S()
       end
       asqrt = setcoeff!(asqrt, i, sqrt(c; check=false))
@@ -585,7 +585,7 @@ function sqrt_classical(a::FqRelPowerSeriesRingElem; check::Bool=true)
    z.val = v2
    c = coeff(a, v)
    if check
-      flag, s = issquare_with_sqrt(c)
+      flag, s = is_square_with_sqrt(c)
       if !flag
          return false, S()
       end
@@ -611,12 +611,12 @@ function Base.sqrt(a::FqRelPowerSeriesRingElem; check::Bool=true)
    return q
 end
 
-function issquare(a::FqRelPowerSeriesRingElem)
+function is_square(a::FqRelPowerSeriesRingElem)
    flag, q = sqrt_classical(a; check=true)
    return flag
 end
 
-function issquare_with_sqrt(a::FqRelPowerSeriesRingElem)
+function is_square_with_sqrt(a::FqRelPowerSeriesRingElem)
    return sqrt_classical(a; check=true)
 end
 

src/flint/fq_nmod_poly.jl

@@ -400,7 +400,7 @@ function sqrt(x::fqPolyRepPolyRingElem; check::Bool=true)
    return s
 end
 
-function issquare(x::fqPolyRepPolyRingElem)
+function is_square(x::fqPolyRepPolyRingElem)
    if iszero(x)
       return true
    end
@@ -415,7 +415,7 @@ function issquare(x::fqPolyRepPolyRingElem)
    return flag
 end
 
-function issquare_with_sqrt(x::fqPolyRepPolyRingElem)
+function is_square_with_sqrt(x::fqPolyRepPolyRingElem)
    R = parent(x)
    if iszero(x)
       return true, zero(R)

src/flint/fq_poly.jl

@@ -400,7 +400,7 @@ function sqrt(x::FqPolyRepPolyRingElem; check::Bool=true)
    return s
 end
 
-function issquare(x::FqPolyRepPolyRingElem)
+function is_square(x::FqPolyRepPolyRingElem)
    if iszero(x)
       return true
    end
@@ -415,7 +415,7 @@ function issquare(x::FqPolyRepPolyRingElem)
    return flag
 end
 
-function issquare_with_sqrt(x::FqPolyRepPolyRingElem)
+function is_square_with_sqrt(x::FqPolyRepPolyRingElem)
    R = parent(x)
    if iszero(x)
       return true, zero(R)

src/flint/fq_rel_series.jl

@@ -571,7 +571,7 @@ function sqrt_classical_char2(a::($etype); check::Bool=true)
    end
    for i = 0:prec - aval2 - 1
       c = polcoeff(a, 2*i)
-      if check && !issquare(c)
+      if check && !is_square(c)
          return false, S()
       end
       asqrt = setcoeff!(asqrt, i, sqrt(c; check=false))
@@ -600,7 +600,7 @@ function sqrt_classical(a::($etype); check::Bool=true)
    z.val = v2
    c = coeff(a, v)
    if check
-      flag, s = issquare_with_sqrt(c)
+      flag, s = is_square_with_sqrt(c)
       if !flag
          return false, S()
       end
@@ -626,12 +626,12 @@ function Base.sqrt(a::($etype); check::Bool=true)
    return q
 end
 
-function issquare(a::($etype))
+function is_square(a::($etype))
    flag, q = sqrt_classical(a; check=true)
    return flag
 end
 
-function issquare_with_sqrt(a::($etype))
+function is_square_with_sqrt(a::($etype))
    return sqrt_classical(a; check=true)
 end
 

src/flint/gfp_fmpz_poly.jl

@@ -325,15 +325,15 @@ function Base.sqrt(x::FpPolyRingElem; check::Bool=true)
    return s
 end
 
-function issquare(x::FpPolyRingElem)
+function is_square(x::FpPolyRingElem)
    s = parent(x)()
    flag = Bool(ccall((:fmpz_mod_poly_sqrt, libflint), Cint,
                      (Ref{FpPolyRingElem}, Ref{FpPolyRingElem}, Ref{fmpz_mod_ctx_struct}),
                       s, x, x.parent.base_ring.ninv))
    return flag
 end
 
-function issquare_with_sqrt(x::FpPolyRingElem)
+function is_square_with_sqrt(x::FpPolyRingElem)
    s = parent(x)()
    flag = Bool(ccall((:fmpz_mod_poly_sqrt, libflint), Cint,
                      (Ref{FpPolyRingElem}, Ref{FpPolyRingElem}, Ref{fmpz_mod_ctx_struct}),