fix: make compiler happier (#1648)

- remove the zero argument versions of vcat and hcat
Nemocas · Apr 3, 2024 · e5f6d9b · e5f6d9b
1 parent 9fcd8ce
commit e5f6d9b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,6 +1,6 @@
 name = "AbstractAlgebra"
 uuid = "c3fe647b-3220-5bb0-a1ea-a7954cac585d"
-version = "0.40.4"
+version = "0.40.5"
 
 [deps]
 InteractiveUtils = "b77e0a4c-d291-57a0-90e8-8db25a27a240"

diff --git a/src/Matrix.jl b/src/Matrix.jl
@@ -6361,8 +6361,8 @@ end
 Return the horizontal concatenation of the matrices $A$.
 All component matrices need to have the same base ring and number of columns.
 """
-function Base.vcat(A::MatrixElem{T}...) where T <: NCRingElement
-  return _vcat(A)
+function Base.vcat(A0::MatrixElem{T}, A::MatrixElem{T}...) where T <: NCRingElement
+  return _vcat((A0, A...))
 end
 
 # this leads to an ambiguity when calling `reduce(hcat, Union{}[])`, but we don't have a better solution right now
@@ -6400,8 +6400,8 @@ end
 Return the horizontal concatenating of the matrices $A$.
 All component matrices need to have the same base ring and number of rows.
 """
-function Base.hcat(A::MatrixElem{T}...) where T <: NCRingElement
-  return _hcat(A)
+function Base.hcat(A0::MatrixElem{T}, A::MatrixElem{T}...) where T <: NCRingElement
+  return _hcat((A0, A...))
 end
 
 # this leads to an ambiguity when calling `reduce(hcat, Union{}[])`, but we don't have a better solution right now