Documentation #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// exists in the set will update its value, otherwise will add a new | ||
| /// attribute to the set. | ||
| /// exists in the list will update its value, otherwise will add a new | ||
| /// attribute to the list. |
There was a problem hiding this comment.
I think this sounds better: If the attribute already exists in the list, update its value, otherwise add a new attribute to the list..
|
Except for those minor corrections, it looks very good! 👍 |
|
If you're done with docs, I'll try the 'Update branch' button and merge this... |
|
👍 |
|
Hmm... A reverse merge! Now there'll be another merge commit! |
|
Hmm, yeah, I prefer GitLab's "rebase branch". I could rebase and force push this if you want? |
Alright! I was almost at the merge button!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds documentation for all public items and enables the warning for missing it. Had to add an implementation of
EqtoTokento make the doc tests for that easy to write, but I think it makes sense to have it; as far as I can tell the only way it can sort of fail is if you have duplicated attributes in different orders.