Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Fetching available theaters with escape game #15

Merged
merged 7 commits into from
Nov 7, 2023

Conversation

massdx
Copy link
Collaborator

@massdx massdx commented Nov 1, 2023

Fetching available theaters with escape game

Description

Added getAllEscapeGames method in theaters controller to fetch all available theaters with escape game.
Created /escape-game route in theaters route.
Added theaters-escape-game.model.ts in models.
tested the end-point

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@NemesisX1 NemesisX1 self-requested a review November 1, 2023 22:53
Copy link
Owner

@NemesisX1 NemesisX1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, can you add tests in the scrapping-service.test.ts file about the new scrapping function you added in the ScrappingService ?

I will be really cool too if you can add docs in its related route

@massdx
Copy link
Collaborator Author

massdx commented Nov 4, 2023

I'm not doing too well with Swager's doc but he'll try

@NemesisX1
Copy link
Owner

I'm not doing too well with Swager's doc but he'll try

The swagger docs is not a requirement don't worry. But if you wanna do it you can have a look at this one https://swagger-autogen.github.io/docs/

@NemesisX1 NemesisX1 merged commit 7cd0ea2 into NemesisX1:main Nov 7, 2023
1 check passed
@massdx massdx deleted the escape-game branch November 7, 2023 10:53
@massdx
Copy link
Collaborator Author

massdx commented Nov 7, 2023

ok thanks i will do it

@NemesisX1
Copy link
Owner

@massdx I've made some refactoring directly in the main branch. You can get a look at it. I also added docs and English language support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants