Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra convenience options for no caption and no thumbnail #56

Merged
merged 5 commits into from
Sep 5, 2020

Conversation

cristian64
Copy link
Contributor

  • --no-thumbnail option has been added.
  • --caption "" is now respected. Previously, it would fallback to the file name (without extension), even if the user had explicitly specified an empty string.
  • With --force-file, the file path was wrongly being used, instead of the file name.

@Nekmo Nekmo force-pushed the master branch 2 times, most recently from e8b842a to a5a4834 Compare September 2, 2020 20:04
@Nekmo Nekmo self-assigned this Sep 2, 2020
@Nekmo Nekmo added this to the v0.4.0 milestone Sep 2, 2020
@cristian64 cristian64 force-pushed the add_extra_convenience_options branch from 5cfb86b to ebdcd5b Compare September 2, 2020 22:43
@cristian64 cristian64 force-pushed the add_extra_convenience_options branch from ebdcd5b to 379ae07 Compare September 2, 2020 22:49
@cristian64
Copy link
Contributor Author

  • Rebased.
  • Reordered some commits.

@Nekmo
Copy link
Owner

Nekmo commented Sep 5, 2020

Tested:

  • Using file name over file path when using --force-file option.
  • Extra convenience options for no caption and no thumbnail
  • Added --no-thumbnail option to opt-out from thumbnail generation.
  • Removed redundant except Exception: raise clause.
  • Added double quotes in print statement around file path, as it may co…

@Nekmo
Copy link
Owner

Nekmo commented Sep 5, 2020

Thanks! :)

You can add your name to the list of contributors in a pull request.

https://github.com/Nekmo/telegram-upload/blob/master/AUTHORS.rst

@Nekmo Nekmo merged commit a873b38 into Nekmo:master Sep 5, 2020
@Nekmo
Copy link
Owner

Nekmo commented Sep 11, 2020

@cristian64 I have added you to the authors.rst. You can add your email/website/twitter if you want. You can also remove your name if you do not want to appear.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants