Fixes close tabs to the left/right

when you have multiple tab pages Resolves brave#9789 Auditors: @bsclifton Test Plan:
NejcZdovc · Jul 12, 2017 · 84aee6e · 84aee6e
1 parent c8e92a1
commit 84aee6e
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 11 deletions.
diff --git a/app/renderer/reducers/frameReducer.js b/app/renderer/reducers/frameReducer.js
@@ -186,21 +186,33 @@ const frameReducer = (state, action, immutableAction) => {
       })
       break
     case windowConstants.WINDOW_CLOSE_OTHER_FRAMES:
-      const currentIndex = frameStateUtil.getIndexByTabId(state, action.tabId)
-      if (currentIndex === -1) {
-        return
-      }
+      {
+        const currentIndex = frameStateUtil.getIndexByTabId(state, action.tabId)
+        if (currentIndex === -1) {
+          return
+        }
 
-      state.get('frames').forEach((frame, i) => {
-        if (!frame.get('pinnedLocation') &&
-          ((i < currentIndex && action.isCloseLeft) || (i > currentIndex && action.isCloseRight))) {
-          if (frame) {
-            appActions.tabCloseRequested(frame.get('tabId'))
+        let tabs = []
+
+        state.get('frames').forEach((frame, i) => {
+          if (!frame.get('pinnedLocation') &&
+            ((i < currentIndex && action.isCloseLeft) || (i > currentIndex && action.isCloseRight))) {
+            if (frame) {
+              tabs.push(frame.get('tabId'))
+              appActions.tabCloseRequested(frame.get('tabId'))
+            }
           }
-        }
-      })
+        })
 
+        // TODO(nejc) this can be simplified when states are merged
+        const newFrames = state.get('frames').filter(frame => !tabs.includes(frame.get('tabId')))
+        let newState = state.set('frames', newFrames)
+        newState = frameStateUtil.updateTabPageIndex(newState, action.tabId)
+        const index = newState.getIn(['ui', 'tabs', 'tabPageIndex'], 0)
+        state = state.setIn(['ui', 'tabs', 'tabPageIndex'], index)
+      }
       break
+
     case windowConstants.WINDOW_CLOSE_FRAME:
       state = closeFrame(state, action)
       break

diff --git a/test/tab-components/tabPagesTest.js b/test/tab-components/tabPagesTest.js
@@ -3,6 +3,7 @@
 const Brave = require('../lib/brave')
 const appConfig = require('../../js/constants/appConfig')
 const settings = require('../../js/constants/settings')
+const messages = require('../../js/constants/messages')
 const {
   urlInput,
   newFrameButton,
@@ -68,6 +69,15 @@ describe('tab pages', function () {
         .waitForElementCount(tabsTabs, numTabsPerPage)
     })
 
+    it('closing tabs with close-to-left option', function * () {
+      yield this.app.client
+        .click(newFrameButton)
+        .waitForElementCount(tabPage, 2)
+        .ipcSend(messages.SHORTCUT_CLOSE_OTHER_FRAMES, 21, false, true)
+        .waitForElementCount(tabPage, 0)
+        .waitForElementCount(tabsTabs, 1)
+    })
+
     describe('allows changing to tab pages', function () {
       beforeEach(function * () {
         // Make sure there are 2 tab pages