Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crypto.kdfDeriveFromInputKeyMaterial zeroes out salt argument #29

Closed
NeilMadden opened this issue Feb 6, 2023 · 0 comments · Fixed by #31
Closed

Crypto.kdfDeriveFromInputKeyMaterial zeroes out salt argument #29

NeilMadden opened this issue Feb 6, 2023 · 0 comments · Fixed by #31
Assignees
@NeilMadden
Labels
bug Something isn't working

Comments

@NeilMadden
Copy link
Owner

After calling Crypto.kdfDeriveFromInputKeyMaterial, the salt parameter, if specified, is zeroed out. As the salt is not a secret input, this is unnecessary and may cause bugs as callers will not expect it to be wiped.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NeilMadden NeilMadden

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #29: don't zero-out HKDF salt argument. NeilMadden/salty-coffee
1 participant
@NeilMadden