Fix createDestDir regression #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skipping `prepareDestination` with `CreateDestDir:false` got dropped in a previous change. This puts it back. Signed-off-by: Blake Devcich <blake.devcich@hpe.com>
matthew-richerson
approved these changes
Sep 24, 2024
ajfloeder
approved these changes
Sep 24, 2024
|
@mcfadden8 FYI |
|
Thanks @bdevcich, will this require a new release of both the containers and of the nnfdm daemon for the compute nodes? |
|
The right way to do this would be to drop a release, but if this is blocking your work and you want it ASAP, the gitops repo could be updated to pull the latest nnf-dm image to bring in this change. No change necessary for the damon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skipping
prepareDestinationwithCreateDestDir:falsegot dropped in a previous change. This puts it back.Signed-off-by: Blake Devcich blake.devcich@hpe.com