Use NnfDataMovementProfiles #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnf-dm uses a configmap to store its configuration in. This is not consistent with the other means of configuration (i.e. Storage and Container Profiles). This change removes the nnf-dm-config map and swaps it with using NnfDataMovementProfiles. Pinned profiles are used for copy_in/copy_out directives. Non-pinned profiles are used for the Copy Offload API since the user can select any profile they wish and can change profiles with each request. This means that the nnf-dm reconciler now needs access to the `nnf-system` namespace to get the non-pinned profiles. Signed-off-by: Blake Devcich <blake.devcich@hpe.com>
roehrich-hpe
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nnf-dm uses a configmap to store its configuration in. This is not consistent with the other means of configuration (i.e. Storage and Container Profiles).
This change removes the nnf-dm-config map and swaps it with using NnfDataMovementProfiles.
Pinned profiles are used for copy_in/copy_out directives. Non-pinned profiles are used for the Copy Offload API since the user can select any profile they wish and can change profiles with each request. This means that the nnf-dm reconciler now needs access to the
nnf-systemnamespace to get the non-pinned profiles.