Parse stats from dcp output #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grab the end stats from dcp output and store it in the command status. Signed-off-by: Blake Devcich <blake.devcich@hpe.com>
bdevcich
commented
Jul 26, 2024
| } | ||
|
|
||
| // Go through the list of dcp stat regexes, parse them, and put them in their appropriate place in cmdStatus | ||
| func parseDcpStats(line string, cmdStatus *nnfv1alpha1.NnfDataMovementCommandStatus) error { |
There was a problem hiding this comment.
I'm all ears if there's a better way to do this
There was a problem hiding this comment.
You just need to add an option to dcp to output in json.
matthew-richerson
approved these changes
Jul 26, 2024
Signed-off-by: Blake Devcich <blake.devcich@hpe.com>
roehrich-hpe
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grab the end stats from dcp output and store it in the command status.
Signed-off-by: Blake Devcich blake.devcich@hpe.com