Release v0.1.3 #187
Merged
Release v0.1.3 #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It wasn't doing a push on merge to the releases/v0 branch. However, other workflows that simply have "on: push" were building on that merge. So, let's try that. Signed-off-by: Dean Roehrich <dean.roehrich@hpe.com>
Signed-off-by: Dean Roehrich <dean.roehrich@hpe.com>
Add component/version labels to each resource in the manifest. If run locally the labels will be: app.kubernetes.io/component: nnf-dm app.kubernetes.io/version: <git-version-gen> If run from nnf-deploy's "make manifests" the labels will be: app.kubernetes.io/component: nnf-dm app.kubernetes.io/version: <nnf-dm's git-version-gen> app.kubernetes.io/part-of: nnf app.kubernetes.io/nnf-version: <nnf-deploy's git-version-gen> Signed-off-by: Dean Roehrich <dean.roehrich@hpe.com>
Signed-off-by: Dean Roehrich <dean.roehrich@hpe.com>
Change make-kustomization.sh to add component/version labels only to Deployment/Daemonset in the manifest. By doing only these resources, rather than all resources, we minimize the noise in a manifest update to the gitops repo. If run locally the labels will be: app.kubernetes.io/component: nnf-dm app.kubernetes.io/version: <git-version-gen> If run from nnf-deploy's "make manifests" the labels will be: app.kubernetes.io/component: nnf-dm app.kubernetes.io/version: <nnf-dm's git-version-gen> app.kubernetes.io/part-of: nnf app.kubernetes.io/nnf-version: <nnf-deploy's git-version-gen> Signed-off-by: Dean Roehrich <dean.roehrich@hpe.com>
Signed-off-by: Dean Roehrich <dean.roehrich@hpe.com>
Signed-off-by: Blake Devcich <blake.devcich@hpe.com>
Signed-off-by: Blake Devcich <blake.devcich@hpe.com>
Signed-off-by: Blake Devcich <blake.devcich@hpe.com>
roehrich-hpe
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release v0.1.3