Daemon RPM build rework #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build the daemon in an environment defined by a Dockerfile, and build it with the same environment whether it's built locally or within a workflow. Using `make build-daemon` will build the daemon locally as always and continue to drop it into the local bin/ directory. Using `make build-daemon-rpm` will build the daemon within the container environment and will drop the resulting rpm in a local rpm/ directory. In tests so far, this tends to cut the build time within the workflow to about 1/3 of the time that we've seen in the past. Signed-off-by: Dean Roehrich <dean.roehrich@hpe.com>
ajfloeder
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build the daemon in an environment defined by a Dockerfile, and build it with the same environment whether it's built locally or within a workflow.
Using
make build-daemonwill build the daemon locally as always and continue to drop it into the local bin/ directory.Using
make build-daemon-rpmwill build the daemon within the container environment and will drop the resulting rpm in a local rpm/ directory.In tests so far, this tends to cut the build time within the workflow to about 1/3 of the time that we've seen in the past.