Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a separate ServiceAccount for the node-level controller #172

Merged
merged 1 commit into from
Apr 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/manager/manager.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ spec:
maxUnavailable: '25%'
template:
spec:
serviceAccountName: nnf-dm-controller-manager # not sure why 'controller-manager' isn't patched to include the 'nnf-dm-' prefix
serviceAccountName: nnf-dm-node-controller
tolerations:
- key: 'cray.nnf.node'
operator: 'Equal'
Expand Down
15 changes: 14 additions & 1 deletion config/rbac/role_binding.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,17 @@ roleRef:
subjects:
- kind: ServiceAccount
name: controller-manager
namespace: system
namespace: system
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
name: node-manager-rolebinding
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: ClusterRole
name: manager-role
subjects:
- kind: ServiceAccount
name: node-controller
namespace: system
18 changes: 17 additions & 1 deletion config/rbac/service_account.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,20 @@ metadata:
annotations:
kubernetes.io/service-account.name: controller-manager
kubernetes.io/service-account.namespace: system
type: kubernetes.io/service-account-token
type: kubernetes.io/service-account-token
---
apiVersion: v1
kind: ServiceAccount
metadata:
name: node-controller
namespace: system
---
apiVersion: v1
kind: Secret
metadata:
name: node-controller
namespace: system
annotations:
kubernetes.io/service-account.name: node-controller
kubernetes.io/service-account.namespace: system
type: kubernetes.io/service-account-token
Loading