Eth2Client: improvements, refactoring #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sept-en
suggested changes
Mar 29, 2023
There was a problem hiding this comment.
Having these changes, we also need to add an extra verification to make sure that the chain is convergent. So block_hash_safe() method would need to add a check that the block is safe only when block_number <= finalized_execution_header.block_number.
But consequently, this also means that finalized_execution_blocks variable no longer represents finalized blocks because the only finalized_execution_header is actually final.
olga24912
approved these changes
Mar 30, 2023
karim-en
force-pushed
the
refactoring-eth2-client
branch
from
f690671
to
aefaec1
Compare
olga24912
approved these changes
Apr 4, 2023
* utilize client modes for light client and execution blocks submission. * add checks for unfinalized tail block number. * add binsearch for a slot by block number. * delete unused functions. * remove irrelevant tests. * fix tests. --------- Co-authored-by: Karim <karim@aurora.dev> Co-authored-by: Kirill <kirill@aurora.dev>
sept-en
changed the title
sept-en
changed the title
sept-en
added
enhancement
dependencies
* set `bitvec` version to 0.1.0. * set `hex` version to 0.4.3.
sept-en
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the eth2 light client to resolve an issue of missing finality for more than 5 epochs.
SubmitLightClientUpdateandSubmitHeader.SubmitLightClientUpdateand it turns intoSubmitHeaderafter submitting a light client update.LightClientUpdateafter any number of epochs/blocks, but those can be finalized only if the size of the gap between the current finalized block and the subsequent finalized block is higher thanhashes_gc_threshold, otherwise, theGCcan't be applied correctly.eth2nearcrates to v0.3.0.