Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nayduck nightly build is broken #3

Closed
bowenwang1996 opened this issue Jul 7, 2021 · 5 comments
Closed

Nayduck nightly build is broken #3

bowenwang1996 opened this issue Jul 7, 2021 · 5 comments
Assignees
Labels
bug Something isn't working T-nodeX

Comments

@bowenwang1996
Copy link

Nightly build is broken. See http://nayduck.eastus.cloudapp.azure.com:3000/#/build/1469 for example

@bowenwang1996 bowenwang1996 added the bug Something isn't working label Jul 7, 2021
@mina86
Copy link
Contributor

mina86 commented Jul 8, 2021

Looks like cargo is broken. This fails:

cargo build -p neard -p genesis-populate -p restaked \
            -p near-test-contracts --features adversarial \
            --features nightly_protocol,nightly_protocol_features

while this works:

cargo build -p neard --features adversarial \
            --features nightly_protocol,nightly_protocol_features
cargo build -j8 -p genesis-populate -p restaked -p near-test-contracts

@bowenwang1996
Copy link
Author

@mina86 does that mean one of genesis-populate, restaked, and near-test-contracts cannot be built with nightly features? We should probably fix that

@mina86
Copy link
Contributor

mina86 commented Jul 9, 2021

Those packages do not define those features. I’m pretty sure that running the two commands separately is a valid solution.

@mina86
Copy link
Contributor

mina86 commented Jul 13, 2021

The above works for the listed packages but there’s also issue with:

cargo test --no-run --target-dir target_expensive -p near-client -p near-chunks -p neard -p near-chain --features=expensive_tests --features nightly_protocol --features nightly_protocol_features

Building all but the near-client works but then building just near-client fails:

   Compiling near-epoch-manager v0.0.1 (/home/mpn/code/near/nearcore/chain/epoch_manager)
   Compiling near-chunks v0.1.0 (/home/mpn/code/near/nearcore/chain/chunks)
error[E0574]: expected struct, variant or union type, found enum `BlockInfo`
   --> chain/epoch_manager/src/test_utils.rs:315:5
    |
315 |     BlockInfo {
    |     ^^^^^^^^^ not a struct, variant or union type

Part of the issue is rust-lang/cargo#6915 which prevents features from selecting features on dev-dependencies.

@bowenwang1996
Copy link
Author

@mina86 so maybe we should tackle near/nearcore#4357 first

@mina86 mina86 closed this as completed in 76bcae5 Jul 26, 2021
mina86 pushed a commit that referenced this issue Jul 29, 2021
mina86 added a commit that referenced this issue Jul 29, 2021
I’m not entirely sure why, but build fails when building all the
packages together:

    cargo build -p neard -p genesis-populate -p restaked \
                -p near-test-contracts --features adversarial \
                --features nightly_protocol,nightly_protocol_features
    […]
    error[E0063]: missing field `evm_chain_id` in initializer of `ApplyState`
       --> test-utils/testlib/src/user/runtime_user.rs:131:9
        |
    131 |         ApplyState {
        |         ^^^^^^^^^^ missing `evm_chain_id`

    error[E0063]: missing field `evm_chain_id` in initializer of `ViewApplyState`
       --> test-utils/testlib/src/user/runtime_user.rs:246:26
        |
    246 |         let view_state = ViewApplyState {
        |                          ^^^^^^^^^^^^^^ missing `evm_chain_id`

    error: aborting due to 2 previous errors

However, things work fine if `neard` is built separately from the
other packages.  It has to do with `protocol_feature_evm` which is not
enabled in `testlib` when necessary.  Whatever the case may be, split
the build into two commands.

Fixes: #3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working T-nodeX
Projects
None yet
Development

No branches or pull requests

3 participants