fix: fix broken backward compatibility of storage deposit logic #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karim-en
force-pushed
the
remove-storage-deposit
branch
from
2140d4e to
441f004
Compare
karim-en
changed the title
|
Gas is reduced because we check whether storage deposit is required? |
olga24912
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Eth wallet contract fails to call the
ft_transferdue to a gas error.This PR includes two fixes:
1- Reduce the gas consumption of the
ft_transfer2-
storage_balance_ofnow returns0instead ofNoneso the wallet contract will not fail during thestorage_depositcall.Example of the failed transactions:
https://testnet.nearblocks.io/txns/0xb0dfd4298715ff8b0cc721fa23e9bc3921755f9d432865ce84275183bde97ca0#enhanced
https://testnet.nearblocks.io/txns/CTyZWBzs3bep8qT3V2xrfBRKCNLUpcvjcnPkABCUzTAH#enhanced
Tx after this fix:
https://testnet.nearblocks.io/txns/0x2c2c5736f3f2600de814aee19108472c24aeb450a1d9eeb6ac7aff0b7a1db338#enhanced
Performance / NEAR gas cost considerations
Testing
How should this be reviewed
Additional information