Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented Transfers service #1

Merged
merged 3 commits into from
Feb 1, 2025
Merged

Implemented Transfers service #1

merged 3 commits into from
Feb 1, 2025

Conversation

I-Frostbyte
Copy link
Contributor

@I-Frostbyte I-Frostbyte commented Jan 29, 2025 •
edited
Loading

  • Created Transfers service with single method: Query
  • Added transfers service to client.go
  • Created transfers.go file to hold the TransferRateResponse struct
  • Structured the Transfers service test to expect a default TrasnferRateResponse struce declared within /internal/stubs/api_responses.go
  • Ran tests and all passed.
  • Test coverage at 71.1%.

AchoArnold
AchoArnold reviewed Jan 30, 2025
View reviewed changes
transfers.go Show resolved Hide resolved
client.go Show resolved Hide resolved
AchoArnold
AchoArnold requested changes Jan 30, 2025
View reviewed changes
transfers_service_test.go Outdated Show resolved Hide resolved
@AchoArnold AchoArnold merged commit 2b959f8 into NdoleStudio:main Feb 1, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AchoArnold AchoArnold AchoArnold requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@I-Frostbyte @AchoArnold