Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[publint] 개선 #27

Merged
merged 3 commits into from
Mar 10, 2025
Merged

[publint] 개선 #27

merged 3 commits into from
Mar 10, 2025

Conversation

byhhh2
Copy link
Contributor

@byhhh2 byhhh2 commented Mar 10, 2025

Related Issue

Describe your changes

  • 에러 메시지 영어로 통일
  • js API로 제공하는 경우 에러 로깅 제거 (cli에서만 로그)

Request

  • [publint] skip 옵션 제공 #26 (comment) 의견에 따라 publint에는 따로 skip 옵션을 주지 않고 pite에서 로깅 레벨을 option으로 주겠습니다.
    • pite 최신화 hidash#217 를 참고하면 배럴 파일이 없는 패키지인데 main, module, types 필드를 채우라고 오류가 남
    • 현재 구조가 main, module, types만 검사하지 않도록 제거할 수 있는 구조가 아님 => 각 필드별로 검사 제외하도록 코드 수정함 => 근데 필드를 하나하나 옵션으로 받는게 너무 사소할 것 같아서.. noBarrel 옵션을 받을까 했는데..아이디어를 주셔서 로깅 레벨을 옵션으로 받아도 괜찮을 듯 함 (pite에서)

@byhhh2 byhhh2 self-assigned this Mar 10, 2025
@byhhh2 byhhh2 requested a review from a team as a code owner March 10, 2025 05:16
2-one-week
2-one-week previously approved these changes Mar 10, 2025
Copy link
Member

@2-one-week 2-one-week left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다

@byhhh2
Copy link
Contributor Author

byhhh2 commented Mar 10, 2025

@2-one-week 님!!
changeset 추가했습니다 😅

Copy link
Member

@2-one-week 2-one-week left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다!

@byhhh2 byhhh2 merged commit 6418f8f into main Mar 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants