-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Namespace validation #275
base: master
Are you sure you want to change the base?
Namespace validation #275
Conversation
Thanks for the PR. I'll try to test your changes ASAP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have given a few initial comments. Please check
@amitguptagwl Pushed a few changes. These should improve the performance as well. Please check |
986662b
to
d5e4ea0
Compare
2. Added check for empty namespace URI
@amitguptagwl Suggested changes pushed. Please check and update. |
@amitguptagwl Any updates on this? |
@kk-08 Sorry for the late response. Please check v4 branch that I have pushed recently. As I had already done these changes, I'm avoiding reviewing the code for same purpose. The changes in v4 are almost done. But I've not completed all the tests yet. As soon I migrate all the tests from master branch to v4 branch. I would be in the condition to publish them. However, there may be some additional changes before going live but that decision can be taken later. |
@kk-08 v4 is live now. And changes seem useful, could you please fix the conflicts so I can review and merge the PR. |
Purpose / Goal
Adds namespace validation for XML
Closes #265
Type
Description
Perf test results:
Before
validation : 12267.12026907211 requests/second
xml to json : 15042.8615171619 requests/second
xml to json + json string : 13716.406269165005 requests/second
xml to json string : 2662.81536578866 requests/second
xml2js : 5438.29834726833 requests/second
After
validation : 13867.26753315293 requests/second
xml to json : 16933.889511481724 requests/second
xml to json + json string : 15117.827735598856 requests/second
xml to json string : 2567.4248020602818 requests/second
xml2js : 4739.0545687362255 requests/second