Fix assert in OCIODisplay plugin when premult param is set. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted unused copyPixelData() functions from all OCIO plugins. Signed-off-by: Aaron Colwell <300262+acolwell@users.noreply.github.com>
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an assert in the OCIODisplay plugin when the premult param is set. The comment above the assert in copyPixelData() indicates that !unpremult && premult should never happen, but a call to this function in OCIODisplayPlugin::render() does allow this to happen when the premult param is set. I've added the necessary code to handle this situation. I verified the behavior by creating a node graph that compares the output of an OCIODisplay node with premult unchecked against the output of a Premult -> OCIODisplay(w/ premult checked)->Unpremult set of nodes.
I also discovered that there were several unused copyPixelData() methods in the OCIODisplay and the other OCIO plugins so I've removed them.