-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shiboken generation in QMake for Python bindings #803
Conversation
1dacbc6
to
07ed75f
Compare
c02990e
to
e2495d1
Compare
If this breaks with Qt4/QMake4, this PR should be against RB-2.6, because Natron 2.5 is with Qt4 and Python3. |
Quoting from #800
QMake 4 as of now uses the generated sources at |
can you please:
|
also please make sure that runPostShiboken.sh and runPostShiboken2.sh pass
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments above
e2495d1
to
f5043f7
Compare
I've removed the sections of manual Qt5 generation as it's done by QMake per the PR.
This surely was produced by the absence of the
|
e8d1164
to
3d5c6a9
Compare
macports package doesn't have a shiboken2.pc nor a pyside2.pc file. Probably a packaging issue |
Then either the macports Portfile needs to ship those
|
I'm having my doubts why would someone run manually run Shiboken2 with this PR 🤔, though Thanks for merging anyways. |
Please don't break the qt4 stuff. |
Damn, you are right! We need to revert this (at least partially), opening a PR then. |
PR #830 is up for reviews. |
Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:
PR Description
What type of PR is this? (Check one of the boxes below)
What does this pull request do?
Currently for the Python bindings we're relying on an static generation of them, but this introduces many problems regarding version compatibility with Python, Qt5, Shiboken2 and PySide2 plus platform dependent issues as well.
Instead this PR lets QMake do the job for us by the usage of targets and generated sources. Dependency on both sources and headers is supported too in case any one of them had been modified.
Show a few screenshots (if this is a visual change)
N/A.
Have you tested your changes (if applicable)? If so, how?
By building Natron.
Futher details of this pull request
Not yet tested with Qt4. This might fail on Windows (specially MsBuild) due to the use of some used Make semantics. May supersede #800.