Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renovate QWheelEvent in Gui #723

Merged
merged 1 commit into from
Dec 14, 2021
Merged

Renovate QWheelEvent in Gui #723

merged 1 commit into from
Dec 14, 2021

Conversation

YakoYakoYokuYoku
Copy link
Member

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:

PR Description

What type of PR is this? (Check one of the boxes below)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality nor fixes a bug but improves Natron in some way)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
    • I have updated the documentation accordingly

What does this pull request do?

QWheelEvent has many deprecated members in Qt 5 and usages like deltas, horizontal scrolls or positions are replaced with methods that returns QPoints that hold the relevant values.

Show a few screenshots (if this is a visual change)

N/A.

Have you tested your changes (if applicable)? If so, how?

Built Natron and used the node graph editor.

Futher details of this pull request

N/A.

@YakoYakoYokuYoku YakoYakoYokuYoku merged commit 4801b02 into RB-2.5 Dec 14, 2021
@YakoYakoYokuYoku YakoYakoYokuYoku deleted the qwheelevent-renov branch December 14, 2021 00:03
@devernay
Copy link
Member

devernay commented Dec 14, 2021

What OS are you testing this on? Are you also testing on a laptop with a multi-touch trackpad that allows scrolling (for testing the wheel events)

@devernay
Copy link
Member

Also, are you testing the Qt5 version on a hiDPI display? linux, mac, windows? I had to fix something for retina on macOS, and wanted to be sure it didn't break others.
BTW we may have to release a 2.6 alpha with Qt5 soon, at least on macOS, because Qt4 is invariably crashing on macOS Monterey

@YakoYakoYokuYoku
Copy link
Member Author

I'm testing this on Solus, a Linux desktop distro. At the moment I'm with my PC tower only so I cannot test with a laptop. Also my monitor DPI has 96 dots per inch so no validations with hiDPI either.

@YakoYakoYokuYoku
Copy link
Member Author

If we want to release an alpha sooner I'll start volleying other commits that I have in my local branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants