Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview isn't rendered after changing value in Properties bin, etc. #708

Closed
yozba opened this issue Nov 24, 2021 · 2 comments
Closed

Preview isn't rendered after changing value in Properties bin, etc. #708

yozba opened this issue Nov 24, 2021 · 2 comments

Comments

@yozba
Copy link

yozba commented Nov 24, 2021

For some reason I couldn't post with the new template, so I'll post with this one.
I checked them all except "I've run Natron via the command line and the issue persists"

Problem

I tried to use transform node and I noticed that Interactive Update and some other things isn't woking correctly.

Expected behavior:

In 2.4.0
it works correctly.

ShareXCap_211125_002509.mp4

Actual behavior:

In 2.4.1

  • Preview isn't rendered after undo or changing value in Properties bin.
  • Interactive Update doesn't work correctly even if I disable "refresh viewer only when editing is finished" option in user interface preferences.
ShareXCap_211124_002846.mp4

Steps to Reproduce

  1. Start Natron
  2. Add Transform node and Rectangle node (or something else)
  3. Make sure enabling Interactive Update and disabling "refresh viewer only when editing is finished" option in user interface preferences
  4. Move it in Preview, Undo, change value

Versions

  • Natron version/commit: 2.4.1
  • OS version: Windows 10 and MacBook Pro (MacOS 11.4 Big Sur, intel)
@devernay devernay added this to the 2.4 milestone Nov 25, 2021
@devernay
Copy link
Member

confirmed:

  • if the viewer interact is left untouched, everything works fine (scrub the rotate angle slider to check: viewer is updated live)
  • after using the viewer interact, the viewer is sometimes updated, and live preview doesn't work

maybe a "begin/end edit group" bug in the interact code?

@devernay
Copy link
Member

actions:

  • try Natron 2.4.1 with the 2.4.0 version of the Misc plugins (including SupportExt)
  • try Natron 2.4.0 with the 2.4.1 version of the Misc plugins
  • fix the bug (probably in the Transform plugins)
  • if that's a begin/end issue, make sure on the Natron side that all editBegin() calls are closed after action ends. Issue a warning and close the ones that are still open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants