Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Bug): Red roto-shape outline has a gap between the last and first point #659

Closed
7 of 10 tasks
Shrinks99 opened this issue Jul 25, 2021 · 1 comment
Closed
7 of 10 tasks

(Bug): Red roto-shape outline has a gap between the last and first point #659

Shrinks99 opened this issue Jul 25, 2021 · 1 comment
Labels
func:roto type:bug Something isn't working
Milestone
2.4

Comments

@Shrinks99
Copy link
Contributor

Shrinks99 commented Jul 25, 2021 •
edited
Loading

  • I'm using the latest version of Natron (not required but recommended)
  • I've restarted Natron and the issue persists
  • I've followed the contributing guidelines to the best of my understanding
  • My issue is not on the issue tracker and is not a duplicate of a forum thread
  • This bug is reproducible
  • This issue is not a feature request or a pull request

Natron version

Natron 2.4.1 beta2

Operating system

Windows 10

System specs

No response

Did you install Natron using the official installer?

  • Yes, I used the official installer
  • No, I installed from a binary archive
  • No, I compiled Natron from sources
  • No, I installed Natron via another method

If you installed to a custom '(non-default)' location please include it here':'

No response

What were you trying to do?

Test the new roto changes.

What did you expect to happen? What happened instead?

Roto shapes appear to not be completed in the viewer overlay. They result in the correct pixel output as if they were completed (so obviously they are completed properly) but the red outline is not drawn to cover the full outline of the shape. This is more pronounced with shapes that have smooth curves however can also be seen in cusped bezier shapes at very high zoom levels. This isn't a new issue (I thought it was for some reason) and I have tested as far back as 2.3.15.

Screenshot 2021-07-25 034126

Step-by-step reproduction instructions

  1. Create a roto node
  2. Complete a few roto-shapes with smooth bezier curves
  3. Note the parts of the curve near the end of the last point just before the line connects to the first point.
@Shrinks99 Shrinks99 added the type:bug Something isn't working label Jul 25, 2021
devernay added a commit that referenced this issue Jan 13, 2022
@devernay
fix missing last point in Beziers overlays
234279a 
- unfinished closed Beziers are the same as open Bezier: keep the last point. See variable `isClosed` in `Bezier::deCastelJau`
- closed Bezier should be drawn with a `GL_LINE_LOOP` instead of `GL_LINE_STRIP`. See variable `isLoop` in `RotoPaint::drawOverlay`
- fixes #659
@devernay
Copy link
Member

fixed by 234279a

@devernay devernay moved this to Done in Natron 2.4 Jan 13, 2022
@devernay devernay added this to the 2.4 milestone Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
func:roto type:bug Something isn't working
Projects
Natron 2.4
Status: Done
Milestone
2.4
Development

No branches or pull requests
3 participants
@devernay @Shrinks99 @Echolon