-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDKs: upgrade OpenImageIO to 2.1.10.0 #350
Comments
linux SDK updated |
Also updated on Windows. Will go through my changes on Sunday and do a PR (including the other MINGW-packages). |
OK, nice. You can even jump to 2.0.9. Also, I wouldn't recommend touching the qt, pyside and shiboken packages. |
Ok, will move to 2.0.9 (and check if I got the patch). qt+pyside had to be modified, as they didn't build in the current state on latest MSYS2 (gcc 9.1). I did bump PySide to 1.2.4, but that I can revert (back to 1.2.2). I will try to get as far as possible tomorrow. |
Well if you manage to get pyside working, that's ok to upgrade it too! |
I will try using 1.2.4, if it breaks anything I will revert. Btw, I noticed your comment regarding oiio 2.0.9 and Boost 1.70. I will stay on 2.0.8 until I get Natron up-and-running since I (MSYS) use Boost 1.70 and don't want to break anything at this point. |
What version of SeExpr should be used on Windows? In the SDK script SeEpxr 1.0.1 is still used and needs a patch (https://github.com/NatronGitHub/Natron/blob/RB-2.3/tools/jenkins/include/scripts/build-Windows-sdk.sh#L646) not available in the Natron repo. Upgrade to latest stable? |
The problem is with boost, not oiio. It also breaks building oiio 2.0.8 on linux, with an obscure message. If your build runs OK, then keep it. |
5 patches, actually |
Ok, I didn't have any issues building oiio 2.0.8 against Boost 1.70. Will update SeExpr to 2.11. |
AcademySoftwareFoundation/OpenImageIO#2429 We have crash reports related to this issue. |
It's cool that it was found so quickly. hopefully 2.0.14 will be released early January and have that patch |
If this is critical, I can tag a bug fix release immediately with just this fix. |
Would be nice to have the fix for Natron 2.3.15 release (and would be nice to release that before the end of this month(?)). |
Which is more helpful for you, a release of 2.0.x or 2.1.x? |
@lgritz thank you for your help. I still haven't tested if 2.1 works for us, so a backport to 2.0 would be nice, but as I see it it's just a 2-line patch, so we don't even need an official OIIO release. |
Aha, well easy then. Already backported. Just use OIIO at commit 028cd32fdd for now. |
All platforms now use 2.1.10.x, close. |
This is required for #309 (Chromatic aberration correction in raw files)
Only close this issue when all three SDKs have been upgraded (Windows/mingw64, Linux, macOS/MacPorts)
The text was updated successfully, but these errors were encountered: