Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDKs: upgrade OpenImageIO to 2.1.10.0 #350

Closed
devernay opened this issue May 11, 2019 · 18 comments
Closed

SDKs: upgrade OpenImageIO to 2.1.10.0 #350

devernay opened this issue May 11, 2019 · 18 comments

Comments

@devernay
Copy link
Member

devernay commented May 11, 2019

This is required for #309 (Chromatic aberration correction in raw files)

Only close this issue when all three SDKs have been upgraded (Windows/mingw64, Linux, macOS/MacPorts)

@devernay
Copy link
Member Author

devernay commented Jul 2, 2019

linux SDK updated

@rodlie
Copy link
Contributor

rodlie commented Jul 20, 2019

Also updated on Windows. Will go through my changes on Sunday and do a PR (including the other MINGW-packages).

@devernay
Copy link
Member Author

OK, nice. You can even jump to 2.0.9.
Do not forget to apply that patch: tools/jenkins/include/patches/OpenImageIO/2.0/oiio-2.0.8-invalidatespec.patch

Also, I wouldn't recommend touching the qt, pyside and shiboken packages.
As soon as you have a windows build, it would be nice to upload it to the 2.3.15pre release.

@rodlie
Copy link
Contributor

rodlie commented Jul 21, 2019

Ok, will move to 2.0.9 (and check if I got the patch).

qt+pyside had to be modified, as they didn't build in the current state on latest MSYS2 (gcc 9.1). I did bump PySide to 1.2.4, but that I can revert (back to 1.2.2).

I will try to get as far as possible tomorrow.

@devernay
Copy link
Member Author

Well if you manage to get pyside working, that's ok to upgrade it too!

@rodlie
Copy link
Contributor

rodlie commented Jul 21, 2019

I will try using 1.2.4, if it breaks anything I will revert.

Btw, I noticed your comment regarding oiio 2.0.9 and Boost 1.70. I will stay on 2.0.8 until I get Natron up-and-running since I (MSYS) use Boost 1.70 and don't want to break anything at this point.

@rodlie
Copy link
Contributor

rodlie commented Jul 21, 2019

What version of SeExpr should be used on Windows? In the SDK script SeEpxr 1.0.1 is still used and needs a patch (https://github.com/NatronGitHub/Natron/blob/RB-2.3/tools/jenkins/include/scripts/build-Windows-sdk.sh#L646) not available in the Natron repo. Upgrade to latest stable?

@devernay
Copy link
Member Author

The problem is with boost, not oiio. It also breaks building oiio 2.0.8 on linux, with an obscure message. If your build runs OK, then keep it.
SeExpr is 2.11, and there are at least 4 patches to apply:
https://github.com/NatronGitHub/Natron/blob/RB-2.3/tools/jenkins/include/scripts/pkg/seexpr.sh

@devernay
Copy link
Member Author

5 patches, actually

@rodlie
Copy link
Contributor

rodlie commented Jul 21, 2019

Ok, I didn't have any issues building oiio 2.0.8 against Boost 1.70. Will update SeExpr to 2.11.

@rodlie
Copy link
Contributor

rodlie commented Dec 9, 2019

AcademySoftwareFoundation/OpenImageIO#2429

We have crash reports related to this issue.

@devernay
Copy link
Member Author

devernay commented Dec 9, 2019

It's cool that it was found so quickly. hopefully 2.0.14 will be released early January and have that patch

@lgritz
Copy link

lgritz commented Dec 10, 2019

If this is critical, I can tag a bug fix release immediately with just this fix.

@rodlie
Copy link
Contributor

rodlie commented Dec 11, 2019

Would be nice to have the fix for Natron 2.3.15 release (and would be nice to release that before the end of this month(?)).

@lgritz
Copy link

lgritz commented Dec 12, 2019

Which is more helpful for you, a release of 2.0.x or 2.1.x?

@devernay
Copy link
Member Author

@lgritz thank you for your help. I still haven't tested if 2.1 works for us, so a backport to 2.0 would be nice, but as I see it it's just a 2-line patch, so we don't even need an official OIIO release.

@lgritz
Copy link

lgritz commented Dec 13, 2019

Aha, well easy then. Already backported. Just use OIIO at commit 028cd32fdd for now.

@devernay devernay changed the title SDKs: upgrade OpenImageIO to 2.0.8 SDKs: upgrade OpenImageIO to 2.0.13+patch Dec 23, 2019
@devernay devernay added this to the 2.3 milestone Jan 4, 2020
@devernay devernay changed the title SDKs: upgrade OpenImageIO to 2.0.13+patch SDKs: upgrade OpenImageIO to 2.1.9.0+patch Jan 5, 2020
@devernay devernay changed the title SDKs: upgrade OpenImageIO to 2.1.9.0+patch SDKs: upgrade OpenImageIO to 2.1.10.0 Jan 10, 2020
rodlie added a commit that referenced this issue Jan 13, 2020
lib and utils seems to work, will verify with a unit test. #418 #350
@rodlie
Copy link
Contributor

rodlie commented Jan 22, 2020

All platforms now use 2.1.10.x, close.

@rodlie rodlie closed this as completed Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants