Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update ios and android builds #137

Conversation

Avtrkrb
Copy link
Contributor

@Avtrkrb Avtrkrb commented Feb 14, 2024

  1. Upgrades
  • viroar
  • viroreact
  • virocore
  • sharedCode
  • viro_renderer
  1. ARcore
  • Upgrade arcore 1.26.0 -> 1.41.0
  1. Migrate
  • com.google.android.exoplayer2 -> androidx.media3.exoplayer
  1. Bug fixes
  • com.google.android.exoplayer2 -> androidx.media3.exoplayer

…ded to arcore 1.41.0. Tested with custom app.
@Avtrkrb
Copy link
Contributor Author

Avtrkrb commented Feb 15, 2024

@robertjcolley @cjmcassar

This pr needs to be merged before the this pr on the viro repo.

- Adds build script
@robertjcolley robertjcolley marked this pull request as ready for review February 19, 2024 20:23
Copy link
Collaborator

@robertjcolley robertjcolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! @Avtrkrb can you confirm that you're able to run ./prepare_release.sh here?

Copy link

gitguardian bot commented Feb 19, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- Google API Key e5a9f99 android/releasetest/src/main/AndroidManifest.xml View secret
- Google API Key e5a9f99 android/renderertest/src/main/AndroidManifest.xml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@robertjcolley robertjcolley force-pushed the 260-fix-android-building-with-java-17-kotlin-and-expo branch from 63829a2 to b8c28f0 Compare February 19, 2024 20:37
@robertjcolley robertjcolley changed the title WIP: 260 fix android building with java 17 kotlin and expo fix: android build with java 17 Feb 19, 2024
@robertjcolley robertjcolley self-assigned this Feb 19, 2024
@robertjcolley robertjcolley changed the title fix: android build with java 17 fix: update ios and android builds Feb 19, 2024
@robertjcolley robertjcolley merged commit c37e413 into ReactVision:main Feb 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants