Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip links as supporting library doesn't support that #378

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danielpetrica
Copy link

@danielpetrica danielpetrica commented Sep 29, 2024

This commits adds the skip links option to avoid the lack of support for symbolic links in the underlying flysystem library. This fixes issue https://github.com/orgs/NativePHP/discussions/374 but I'll leave it on draft as I want to test it on a different system too.

Why we need to skip symlinks ?

One classic example that may brake this is the symlinked desktop directory for backups to Onedrive.
I haven't tryid one drive specifically but on my Linux machine my desktop folder and a bunch o other folders links to nextcloud directories so they break the driver system.

Drawbacks

Users can't see symlinked folders (like the desktop folder in the above example), but they can see them if they are defined as root folder.

Testing:

  • Linux
  • Mac
  • Windows ( I don't have a windows machine to test it)

@danielpetrica
Copy link
Author

I'll leave it as draft to be able to test it on mac first

@danielpetrica
Copy link
Author

this works with mac too. But if you try to list all directories recursivelly inside user it still get's an error on special directories like photo library and Applications. Don't know if it's possible to filter them when doing Storage::disk("user_home")->allFiles();

@danielpetrica danielpetrica marked this pull request as ready for review September 30, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant