Skip links as supporting library doesn't support that #378
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits adds the skip links option to avoid the lack of support for symbolic links in the underlying flysystem library. This fixes issue https://github.com/orgs/NativePHP/discussions/374 but I'll leave it on draft as I want to test it on a different system too.
Why we need to skip symlinks ?
One classic example that may brake this is the symlinked desktop directory for backups to Onedrive.
I haven't tryid one drive specifically but on my Linux machine my desktop folder and a bunch o other folders links to nextcloud directories so they break the driver system.
Drawbacks
Users can't see symlinked folders (like the desktop folder in the above example), but they can see them if they are defined as root folder.
Testing: