Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BSim: Rework feature visualizer colors (dark theme) #7312

Merged

Conversation

gemesa
Copy link
Contributor

@gemesa gemesa commented Dec 20, 2024

Fixes #7309

Seems like the BSim feature visualizer is not optimized for the dark theme at the moment. This PR improves it.

Before (1):

image

image

After (1):

image

Before (2):

image

image

After (2):

image

Before (3):

image

image

After (3):

image

@dragonmacher dragonmacher self-assigned this Dec 21, 2024
@dragonmacher dragonmacher self-requested a review December 21, 2024 00:36
@ryanmkurtz ryanmkurtz added Status: Triage Information is being gathered Status: Internal This is being tracked internally by the Ghidra team and removed Status: Triage Information is being gathered labels Dec 27, 2024
@ryanmkurtz ryanmkurtz added this to the 11.3 milestone Jan 2, 2025
@ryanmkurtz ryanmkurtz merged commit 98170e5 into NationalSecurityAgency:master Jan 2, 2025
@gemesa gemesa deleted the bsim-visualizer-dark-mode branch January 2, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Internal This is being tracked internally by the Ghidra team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BSimFeatureVisualizer decompiler highlighting is hard to read in dark mode
3 participants