Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BSimFeatureVisualizer decompiler highlighting is hard to read in dark mode #7309

Closed
gemesa opened this issue Dec 20, 2024 · 2 comments · Fixed by #7312
Closed

BSimFeatureVisualizer decompiler highlighting is hard to read in dark mode #7309

gemesa opened this issue Dec 20, 2024 · 2 comments · Fixed by #7312
Assignees
@dragonmacher
Labels
Status: Internal This is being tracked internally by the Ghidra team
Milestone
11.3

Comments

@gemesa
Copy link
Contributor

gemesa commented Dec 20, 2024 •
edited
Loading

Describe the bug

When inspecting BSim features in BSimFeatureVisualizer, the code highlighted in orange in the decompiler view is often very hard to read in dark mode (see screenshots below).

To Reproduce
Steps to reproduce the behavior:

  1. Go to BSim --> BSim Feature Visualizer
  2. Select a feature in the table
  3. Check the highlighted code in the decompiler view

Expected behavior
Readable highlighted code.

Screenshots

BSimFeatureVisualizer:

image

Decompiler:

image

BSimFeatureVisualizer:

image

Decompiler:

image

BSimFeatureVisualizer:

image

Decompiler:

image

Attachments
N/A

Environment (please complete the following information):

  • OS: Linux fedora 6.12.4-200.fc41.x86_64
  • Java Version: openjdk 21.0.4 2024-07-16 LTS
  • Ghidra Version: 11.3_DEV
  • Ghidra Origin: locally built from the GitHub repo without any changes (commit 8bbc1d054075d0626eba621b470077a17e3dc16a)

Additional context
N/A
@gemesa
Copy link
Contributor Author

gemesa commented Dec 20, 2024

I also tried to find the relevant color option under Tool Options but could not locate it.

@dragonmacher
Copy link
Collaborator

You should be able to change all colors of this feature via the Theme settings from the Front End window.

It looks like each theme color value has the prefix color.bsim.graph. I see 21 different entries defined.

@gemesa gemesa mentioned this issue Dec 20, 2024
Merged
@ryanmkurtz ryanmkurtz added the Status: Triage Information is being gathered label Dec 27, 2024
@ryanmkurtz ryanmkurtz added this to the 11.3 milestone Jan 2, 2025
@ryanmkurtz ryanmkurtz added Status: Internal This is being tracked internally by the Ghidra team and removed Status: Triage Information is being gathered labels Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dragonmacher dragonmacher

Labels
Status: Internal This is being tracked internally by the Ghidra team
Projects
None yet
Milestone
11.3
Development

Successfully merging a pull request may close this issue.

BSim: Rework feature visualizer colors (dark theme) gemesa/ghidra
3 participants
@ryanmkurtz @dragonmacher @gemesa