Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements the chained SSDeep Discovery Query #2242

Merged
merged 3 commits into from
Mar 15, 2024
Merged

Implements the chained SSDeep Discovery Query #2242

merged 3 commits into from
Mar 15, 2024

Conversation

drewfarris
Copy link
Collaborator

No description provided.

@drewfarris drewfarris marked this pull request as draft January 31, 2024 14:52
@drewfarris drewfarris self-assigned this Jan 31, 2024
@drewfarris drewfarris force-pushed the feature/ssdeep-discovery-query-integration branch from 3a8c2cf to 7734fa9 Compare January 31, 2024 20:52
@drewfarris drewfarris force-pushed the feature/ssdeep-similarity-scoring-refactor branch from a36ef94 to 6daa263 Compare February 1, 2024 16:03
@drewfarris drewfarris force-pushed the feature/ssdeep-discovery-query-integration branch from 7734fa9 to d438448 Compare February 1, 2024 16:04
@drewfarris drewfarris force-pushed the feature/ssdeep-similarity-scoring-refactor branch from 6a5ce01 to 72c35fc Compare February 1, 2024 16:20
@drewfarris drewfarris force-pushed the feature/ssdeep-discovery-query-integration branch from d438448 to 0f3f026 Compare February 1, 2024 16:21
@drewfarris drewfarris force-pushed the feature/ssdeep-similarity-scoring-refactor branch from 72c35fc to 894b0fa Compare February 2, 2024 14:10
@drewfarris drewfarris force-pushed the feature/ssdeep-discovery-query-integration branch from 0f3f026 to 379be45 Compare February 2, 2024 14:51
@drewfarris drewfarris force-pushed the feature/ssdeep-similarity-scoring-refactor branch 3 times, most recently from 056c29a to d2f4424 Compare February 16, 2024 22:05
@drewfarris drewfarris force-pushed the feature/ssdeep-discovery-query-integration branch from 49e1194 to 2e785af Compare February 20, 2024 21:39
@drewfarris drewfarris marked this pull request as ready for review February 20, 2024 21:39
@drewfarris drewfarris force-pushed the feature/ssdeep-discovery-query-integration branch from dac0e82 to fa623b2 Compare February 27, 2024 15:39
@drewfarris drewfarris changed the base branch from feature/ssdeep-similarity-scoring-refactor to integration February 29, 2024 20:11
@drewfarris drewfarris force-pushed the feature/ssdeep-discovery-query-integration branch from fa623b2 to c7e1d11 Compare February 29, 2024 20:21
@hlgp
Copy link
Collaborator

hlgp commented Mar 1, 2024

Looking pretty good! I like the tests. Could we get some class descriptors going as well?

apmoriarty
apmoriarty previously approved these changes Mar 13, 2024
View reviewed changes
@drewfarris
Copy link
Collaborator Author

Addressed comments from @hlgp @cogross and @apmoriarty - thanks for the review all.

@drewfarris
Squashed SSDeep Discovery Query PR
310d5af 
* Implements the chained SSDeep Discovery Query
* Added spring configs for SSDeepSimilarityDiscoveryQuery
* Fixed location of MIN_SSDEEP_SCORE_PARAMETER constant definition
* Update findJars, ingest-libs and assembly pom to include ingest-datawave
* sortpom changes
* Updated SSDeepDiscoveryQuery integration with comments from PR
@drewfarris drewfarris force-pushed the feature/ssdeep-discovery-query-integration branch from e036798 to 310d5af Compare March 13, 2024 21:48
apmoriarty
apmoriarty previously approved these changes Mar 14, 2024
View reviewed changes
MiguelRicardos
MiguelRicardos approved these changes Mar 15, 2024
View reviewed changes
Copy link
Collaborator

@MiguelRicardos MiguelRicardos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

cogross
cogross approved these changes Mar 15, 2024
View reviewed changes
Copy link
Collaborator

@cogross cogross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drewfarris drewfarris merged commit cdfbcc2 into integration Mar 15, 2024
3 checks passed
@drewfarris drewfarris deleted the feature/ssdeep-discovery-query-integration branch March 15, 2024 13:28
FineAndDandy
FineAndDandy reviewed Mar 15, 2024
View reviewed changes
Copy link
Collaborator

@FineAndDandy FineAndDandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just address the TODOs

.../query-core/src/main/java/datawave/query/tables/ssdeep/FullSSDeepDiscoveryChainStrategy.java

String queryString = captureScoredMatchesAndBuildQuery(initialQueryResults, scoredMatches);

Query q = new QueryImpl(); // TODO, need to use a factory? don't hardcode this.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO

hgklohr pushed a commit that referenced this pull request Mar 21, 2024
@drewfarris @hgklohr
Implements the chained SSDeep Discovery Query (#2242)
3454db3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FineAndDandy FineAndDandy FineAndDandy left review comments

@cogross cogross cogross approved these changes

@MiguelRicardos MiguelRicardos MiguelRicardos approved these changes

@apmoriarty apmoriarty apmoriarty left review comments

@hlgp hlgp Awaiting requested review from hlgp

Assignees

@drewfarris drewfarris

Labels
Integration Tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@drewfarris @hlgp @FineAndDandy @cogross @apmoriarty @MiguelRicardos